Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Bump version and improve release doc #1602

Merged
merged 3 commits into from
Mar 1, 2024

Conversation

jesse-c
Copy link
Member

@jesse-c jesse-c commented Mar 1, 2024

Bumps the version to match the latest release and improves the release doc, to mention this.

FIXES INFRA-838

@jesse-c jesse-c self-assigned this Mar 1, 2024
@jesse-c jesse-c requested a review from sakoush March 1, 2024 10:16
@jesse-c jesse-c force-pushed the build-improve-version-bump branch from 86f00b0 to 9089283 Compare March 1, 2024 10:19
Copy link
Member

@sakoush sakoush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the pattern is to upgrade the version to the next dev version, so 1.5.0.dev1 in the master branch. For the official releases (on the release branches), the CI will tag the version on them properly.

@jesse-c
Copy link
Member Author

jesse-c commented Mar 1, 2024

Ah, that makes sense. Since it may be 1.4.1.dev too, is it best to leave it as is? Or just pick one and adjust as we need? (I'll do the latter)

@jesse-c jesse-c force-pushed the build-improve-version-bump branch from 9089283 to 504ee61 Compare March 1, 2024 10:43
@jesse-c jesse-c requested a review from sakoush March 1, 2024 10:43
@jesse-c
Copy link
Member Author

jesse-c commented Mar 1, 2024

Changed to 1.5.0.dev1. Thank you!

Copy link
Member

@sakoush sakoush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jesse-c jesse-c merged commit 7ac4351 into SeldonIO:master Mar 1, 2024
26 of 29 checks passed
@jesse-c jesse-c deleted the build-improve-version-bump branch March 1, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants