fix(runtimes): Remove unused Pydantic dependencies #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesse-c
force-pushed
the
remove-unnecessary-pydantic-deps
branch
from
219dd31
to
5ed1fbb
Compare
sakoush
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
LGTM approving assuming comments are sorted before merging:
-
I have a comment on poetry version to be aligned with what we specify during docker build.
-
I also see no
pyproject.tomlchanges for some runtimes e.g. alibi-explain so I am not sure if they were missed?
jesse-c
force-pushed
the
remove-unnecessary-pydantic-deps
branch
from
5ed1fbb
to
0226857
Compare
This is for unused Pydantic dependency declarations. Alibi Explain uses Pydantic [1]. |
These runtimes don't explicitly use Pydantic. Remove the dependency then to make that clear, and to increase flexibility.
jesse-c
force-pushed
the
remove-unnecessary-pydantic-deps
branch
from
0226857
to
6bc0332
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These runtimes don't explicitly use Pydantic. Remove the dependency then to make that clear, and to increase flexibility. A step towards Pydantic v2.