Sync metadata with MLflow's model signature #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriangonz
force-pushed
the
sync-metadata
branch
from
224854b
to
022d546
Compare
adriangonz
force-pushed
the
sync-metadata
branch
3 times, most recently
from
1f07a09
to
eeba837
Compare
added 23 commits
August 31, 2021 16:29
adriangonz
force-pushed
the
sync-metadata
branch
from
eeba837
to
c79626e
Compare
sakoush
reviewed
Sep 6, 2021
| if common_length == -1: | ||
| common_length = elem_length | ||
|
|
||
| if common_length != elem_length: |
There was a problem hiding this comment.
how restrictive is it that we cannot pass different length strings at this stage?
There was a problem hiding this comment.
Good spot. That is partly a limitation of the v2 protocol (and / or gRPC and protobuf). Since we pass everything as a tensor, we only have a flattened list of elements and a shape. Thus, is not possible to have variable lengths.
Having said that I do think that, at the moment, it will accept variable inputs if you use JSON (the codec will also accept inputs looking like ["asd", "hello world", "etc"]). However, that won't work on the way back when we serialise the response.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #164
Fixes #162
Changelog
binaryanddatetimetypes)StringCodec