bug fix tensorflow trainer #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklaise
reviewed
Apr 27, 2022
| @@ -57,6 +57,7 @@ def trainer( | |||
| callbacks | |||
| Callbacks used during training. | |||
| """ | |||
| return_xy = False if not isinstance(dataset, tf.keras.utils.Sequence) and y_train is None else True | |||
There was a problem hiding this comment.
This can be probably simplified to ... if not dataset and ... (would ignore None and empty dataset) ? Similarly could write ... and not y_train ... to use the same pattern. (That being said I see if not isinstance(...) is used on the line below too, so happy to keep this to avoid further changes).
jklaise
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #491 . Requires that, when an explicit dataset is passed to the TensorFlow trainer, it returns
(x, y). This behaviour is the same as what is expected for the PyTorch trainer where we pass a dataloader returning(x, y). Compatible with the usage of the trainer in the outlier, adversarial and drift detectors.