Fix minor Optional Dependency issues #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR addresses this #576 (comment), but we should leave that issue open until this #576 (comment) is also addressed. |
ascillitoe
reviewed
Aug 10, 2022
| @@ -18,6 +18,15 @@ | |||
| )) | |||
|
|
|||
|
|
|||
| """Map used to ensure correct pip install message is generated if a missing optional dependency is detected. This dict | |||
There was a problem hiding this comment.
Nitpick: map -> mapping?
ascillitoe
approved these changes
Aug 10, 2022
There was a problem hiding this comment.
LGTM! One v. minor nitpick, but I might be wrong about the grammar here anyway!
P.s. @mauicv [WIP] needs removing from title prior to merge.
mauicv
changed the title
jklaise
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this
This PR resolves some minor issues namely:
tensorflow_probabilityas well astensorflowwhen issuing the backend validation error