Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fbprophet -> prophet in doc/source/conf.py #684

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

ascillitoe
Copy link
Contributor

@ascillitoe ascillitoe commented Nov 24, 2022

Change fbprophet to prophet in doc/source/conf.py. Following #627.

Fixes the following warning when building docs (without prophet installed):

WARNING: autodoc: failed to import module 'prophet' from module 'alibi_detect.od'; the following exception was raised:
No module named 'prophet'
WARNING: Failed guarded type import with ModuleNotFoundError("No module named 'prophet'")
WARNING: Cannot resolve forward reference in type annotations of "alibi_detect.utils.fetching.fetch_detector": name 'OutlierProphet' is not defined
WARNING: Cannot resolve forward reference in type annotations of "alibi_detect.utils.fetching.fetching.fetch_detector": name 'OutlierProphet' is not defined

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2022

Codecov Report

Merging #684 (71d4b82) into master (9a344ae) will decrease coverage by 0.08%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #684      +/-   ##
==========================================
- Coverage   79.76%   79.67%   -0.09%     
==========================================
  Files         131      131              
  Lines        9133     9133              
==========================================
- Hits         7285     7277       -8     
- Misses       1848     1856       +8     
Flag Coverage Δ
macos-latest-3.10 ?
ubuntu-latest-3.10 79.65% <ø> (ø)
ubuntu-latest-3.7 ?
ubuntu-latest-3.8 ?
ubuntu-latest-3.9 79.59% <ø> (ø)
windows-latest-3.9 76.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
alibi_detect/saving/validators.py 76.92% <0.00%> (-13.47%) ⬇️
alibi_detect/utils/_types.py 95.23% <0.00%> (-4.77%) ⬇️

@ascillitoe ascillitoe removed the request for review from mauicv November 24, 2022 16:05
@ascillitoe ascillitoe merged commit cf01b46 into SeldonIO:master Nov 24, 2022
@ascillitoe ascillitoe deleted the fix/prophet_docs_mock branch November 24, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants