-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert sphinx version to <6.0.0 #708
Merged
ascillitoe
merged 4 commits into
SeldonIO:master
from
ascillitoe:fix/revert_sphinx_versions
Jan 11, 2023
Merged
Revert sphinx version to <6.0.0 #708
ascillitoe
merged 4 commits into
SeldonIO:master
from
ascillitoe:fix/revert_sphinx_versions
Jan 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs compilation errors/warnings with
and previously with
This looks to be the same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert
sphinx
to<6.0.0
since the dependabot CI was not actually testing the new6.x
versions. See #700 (comment).sphinx-autodoc-typehints
was also bumped so this has been reverted.Before the bump to
6.x
versions we were on <5.1.0
.5.1.x
and5.2.x
failed for us due to issues withnbsphinx
. However, I've now upgraded to<6.0.0
because5.3.0
appears to work OK (see below).