Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up's to #681 #723

Closed
wants to merge 5 commits into from

Conversation

ascillitoe
Copy link
Contributor

@ascillitoe ascillitoe commented Jan 19, 2023

Resolves #683

Progress tracker:

  • Item 1: replace cfg = self.config.copy() with deepcopy's.
  • Item 2: replace kernel_a: Union[nn.Module, str] = 'rbf''s with Literal's in the kernel submodules.
  • Item 3: refactor if statements in saving subpackage. - decided just to replace else's with elif's

@ascillitoe ascillitoe added the WIP PR is a Work in Progress label Jan 19, 2023
@ascillitoe ascillitoe removed the WIP PR is a Work in Progress label Jan 19, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2023

Codecov Report

Merging #723 (0502d81) into master (71d41ef) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

❗ Current head 0502d81 differs from pull request most recent head 5ad9237. Consider uploading reports for the commit 5ad9237 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #723      +/-   ##
==========================================
- Coverage   80.15%   80.07%   -0.09%     
==========================================
  Files         133      133              
  Lines        9177     9140      -37     
==========================================
- Hits         7356     7319      -37     
  Misses       1821     1821              
Flag Coverage Δ
macos-latest-3.10 ?
ubuntu-latest-3.10 ?
ubuntu-latest-3.7 79.95% <100.00%> (+<0.01%) ⬆️
ubuntu-latest-3.8 ?
ubuntu-latest-3.9 80.00% <100.00%> (+<0.01%) ⬆️
windows-latest-3.9 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
alibi_detect/utils/pytorch/kernels.py 97.70% <100.00%> (+0.05%) ⬆️
alibi_detect/utils/tensorflow/kernels.py 97.72% <100.00%> (+0.05%) ⬆️
alibi_detect/utils/frameworks.py 88.88% <0.00%> (-3.71%) ⬇️
alibi_detect/saving/validators.py 88.46% <0.00%> (-1.93%) ⬇️
alibi_detect/utils/missing_optional_dependency.py 94.28% <0.00%> (-0.16%) ⬇️
alibi_detect/datasets.py 68.55% <0.00%> (-0.14%) ⬇️
alibi_detect/saving/schemas.py 98.69% <0.00%> (-0.09%) ⬇️
alibi_detect/utils/fetching/fetching.py 0.00% <0.00%> (ø)
alibi_detect/cd/base.py 91.19% <0.00%> (+0.21%) ⬆️
alibi_detect/od/vae.py 90.36% <0.00%> (+1.07%) ⬆️

@ascillitoe ascillitoe added this to the v0.11.0 milestone Jan 19, 2023
@ascillitoe ascillitoe modified the milestones: v0.11.0, v0.11.1 Jan 30, 2023
@ascillitoe ascillitoe closed this by deleting the head repository Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow-up's to #681
2 participants