Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix E721 linting errors #846

Merged
merged 2 commits into from Aug 1, 2023
Merged

Fix E721 linting errors #846

merged 2 commits into from Aug 1, 2023

Conversation

jklaise
Copy link
Member

@jklaise jklaise commented Aug 1, 2023

Some are false positives (see https://www.flake8rules.com/rules/E721.html), I don't think there is a more idiomatic way of checking that two objects are of the same (possibly unknown) type. See also PyCQA/pycodestyle#882.

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #846 (2a63197) into master (c2f0a5a) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #846   +/-   ##
=======================================
  Coverage   81.98%   81.98%           
=======================================
  Files         159      159           
  Lines       10375    10375           
=======================================
  Hits         8506     8506           
  Misses       1869     1869           
Files Changed Coverage Δ
alibi_detect/od/mahalanobis.py 73.88% <100.00%> (ø)
alibi_detect/utils/mapping.py 97.01% <100.00%> (ø)
alibi_detect/utils/pytorch/distance.py 88.63% <100.00%> (ø)
alibi_detect/utils/state/state.py 97.50% <100.00%> (ø)
alibi_detect/utils/tensorflow/distance.py 92.68% <100.00%> (ø)

@jklaise jklaise merged commit ca88d66 into SeldonIO:master Aug 1, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant