Remove deprecated multichannel keyword from skimage.filters.gaussian
#857
Conversation
jklaise
changed the title
skimage.filters.gaussian
alibi_detect/utils/perturbation.py
Outdated
| @@ -561,7 +561,8 @@ def zoom_blur(x: np.ndarray, max_zoom: float, step_zoom: float, xrange: tuple = | |||
| return x_z | |||
|
|
|||
|
|
|||
| def glass_blur(x: np.ndarray, sigma: float, max_delta: int, iterations: int, xrange: tuple = None) -> np.ndarray: | |||
| def glass_blur(x: np.ndarray, sigma: float, max_delta: int, iterations: int, | |||
| channel_axis: int = -1, xrange: tuple = None) -> np.ndarray: | |||
There was a problem hiding this comment.
The public interface has now changed to explicitly include channel_axis, although it's unclear whether the implementation would respect anything other than the default -1 value (it assumes the layout starts with [height, width] axes). Still the function is not used anywhere publicly in the code base or examples so I think this is fine.
There was a problem hiding this comment.
If we're not sure channel_axis actually works for anything other than -1, would it not be safer to remove it as a kwarg and just hard-code it inside glass_blur and gaussian_blur? i.e. just say in docstrings that these functions assume [h, w, c]?
There was a problem hiding this comment.
Agreed, updated here: ceca05a
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #857 +/- ##
=======================================
Coverage 81.98% 81.98%
=======================================
Files 159 159
Lines 10375 10375
=======================================
Hits 8506 8506
Misses 1869 1869
|
Fixes #856.
channel_axiswas introduced in 0.19 so bumping lower bound forscikit-imageto that.