add managed-by label

SeldonIO · Jun 11, 2020 · 6b84f0a · 6b84f0a
1 parent 6f32074
commit 6b84f0a
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 0 deletions.
diff --git a/operator/apis/machinelearning.seldon.io/v1/seldondeployment_types.go b/operator/apis/machinelearning.seldon.io/v1/seldondeployment_types.go
@@ -43,6 +43,8 @@ const (
 	Label_shadow             = "shadow"
 	Label_canary             = "canary"
 	Label_explainer          = "explainer"
+	Label_managed_by         = "app.kubernetes.io/managed-by"
+	Label_value_seldon       = "seldon-core"
 
 	PODINFO_VOLUME_NAME = "seldon-podinfo"
 	PODINFO_VOLUME_PATH = "/etc/podinfo"

diff --git a/operator/controllers/labels.go b/operator/controllers/labels.go
@@ -33,10 +33,12 @@ func addLabelsToService(svc *corev1.Service, pu *machinelearningv1.PredictiveUni
 	if !isEmptyExplainer(p.Explainer) {
 		svc.Labels[machinelearningv1.Label_explainer] = "true"
 	}
+	svc.Labels[machinelearningv1.Label_managed_by] = machinelearningv1.Label_value_seldon
 }
 
 func addLabelsToDeployment(deploy *appsv1.Deployment, containerServiceKey, containerServiceValue string) {
 	deploy.ObjectMeta.Labels[containerServiceKey] = containerServiceValue
 	deploy.Spec.Selector.MatchLabels[containerServiceKey] = containerServiceValue
 	deploy.Spec.Template.ObjectMeta.Labels[containerServiceKey] = containerServiceValue
+	deploy.ObjectMeta.Labels[machinelearningv1.Label_managed_by] = machinelearningv1.Label_value_seldon
 }
diff --git a/operator/controllers/labels_test.go b/operator/controllers/labels_test.go
@@ -34,6 +34,7 @@ func TestAddLabelsToDeployment(t *testing.T) {
 		g.Expect(d.ObjectMeta.Labels["TestKey"]).To(Equal("TestValue"))
 		g.Expect(d.Spec.Selector.MatchLabels["TestKey"]).To(Equal("TestValue"))
 		g.Expect(d.Spec.Template.ObjectMeta.Labels["TestKey"]).To(Equal("TestValue"))
+		g.Expect(d.ObjectMeta.Labels[machinelearningv1.Label_managed_by]).To(Equal(machinelearningv1.Label_value_seldon))
 	})
 }
 
@@ -60,6 +61,7 @@ var _ = Describe("addLabelsToService", func() {
 			addLabelsToService(svc, pu, p)
 
 			Expect(svc.Labels[result]).To(Equal("true"))
+			Expect(svc.Labels[machinelearningv1.Label_managed_by]).To(Equal(machinelearningv1.Label_value_seldon))
 		},
 		Entry("router", machinelearningv1.ROUTER, machinelearningv1.Label_router),
 		Entry("combiner", machinelearningv1.COMBINER, machinelearningv1.Label_combiner),