Fix Strimzi Helm values ZK indent bug + stale broker service name (#492)

* Fix strimzi helm values bug for zookeeper persistent storage * fix kafka bootstrap location to be internal SVC
SeldonIO · Oct 11, 2022 · 8927119 · 8927119
1 parent e801c3d
commit 8927119
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 8 deletions.
diff --git a/k8s/helm-charts/seldon-core-v2-setup/values.yaml b/k8s/helm-charts/seldon-core-v2-setup/values.yaml
@@ -81,7 +81,7 @@ hodometer:
 
 kafka:
   debug:
-  bootstrap: seldon-kafka-plain-bootstrap.seldon-mesh:9092
+  bootstrap: seldon-kafka-bootstrap.seldon-mesh:9092
   consumer:
     sessionTimeoutMs: 6000
     autoOffsetReset: earliest

diff --git a/k8s/helm-charts/seldon-core-v2-setup/values.yaml.template b/k8s/helm-charts/seldon-core-v2-setup/values.yaml.template
@@ -81,7 +81,7 @@ hodometer:
 
 kafka:
   debug:
-  bootstrap: seldon-kafka-plain-bootstrap.seldon-mesh:9092
+  bootstrap: seldon-kafka-bootstrap.seldon-mesh:9092
   consumer:
     sessionTimeoutMs: 6000
     autoOffsetReset: earliest

diff --git a/k8s/samples/values-strimzi-kafka-mtls.yaml b/k8s/samples/values-strimzi-kafka-mtls.yaml
@@ -1,5 +1,5 @@
 kafka:
-  bootstrap: seldon-kafka-tls-bootstrap.seldon-mesh.svc.cluster.local:9093
+  bootstrap: seldon-kafka-bootstrap.seldon-mesh.svc.cluster.local:9093
 
 security:
   kafka:

diff --git a/k8s/yaml/seldon-v2-components.yaml b/k8s/yaml/seldon-v2-components.yaml
@@ -409,7 +409,7 @@ apiVersion: v1
 data:
   kafka.json: |-
     {
-       "bootstrap.servers": "seldon-kafka-plain-bootstrap.seldon-mesh:9092",
+       "bootstrap.servers": "seldon-kafka-bootstrap.seldon-mesh:9092",
        "consumer":{
           "session.timeout.ms":6000,
           "auto.offset.reset":"earliest",
@@ -633,7 +633,7 @@ spec:
       containers:
       - env:
         - name: SELDON_KAFKA_BOOTSTRAP_SERVERS
-          value: seldon-kafka-plain-bootstrap.seldon-mesh:9092
+          value: seldon-kafka-bootstrap.seldon-mesh:9092
         - name: SELDON_UPSTREAM_HOST
           value: seldon-scheduler
         - name: SELDON_UPSTREAM_PORT

diff --git a/kafka/strimzi/values.yaml b/kafka/strimzi/values.yaml
@@ -51,4 +51,4 @@ zookeeper:
     initialDelaySeconds: 15
     timeoutSeconds: 5
 
-    pvcSize: 100Gi
+  pvcSize: 100Gi
diff --git a/scheduler/k8s/config/kafka.yaml b/scheduler/k8s/config/kafka.yaml
@@ -5,7 +5,7 @@ metadata:
 data:
   kafka.json: |-
    {
-      "bootstrap.servers": "seldon-kafka-plain-bootstrap.seldon-mesh:9092",
+      "bootstrap.servers": "seldon-kafka-bootstrap.seldon-mesh:9092",
       "consumer":{
          "session.timeout.ms":6000,
          "auto.offset.reset":"earliest",

diff --git a/scheduler/k8s/dataflow-engine/dataflow-engine.yaml b/scheduler/k8s/dataflow-engine/dataflow-engine.yaml
@@ -22,7 +22,7 @@ spec:
         name: dataflow-engine
         env:
         - name: SELDON_KAFKA_BOOTSTRAP_SERVERS
-          value: "seldon-kafka-plain-bootstrap.seldon-mesh:9092"
+          value: "seldon-kafka-bootstrap.seldon-mesh:9092"
         - name: SELDON_UPSTREAM_HOST
           value: "seldon-scheduler"
         - name: SELDON_UPSTREAM_PORT