Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade k8s client API to 1.18+ #1949

Closed
josephglanville opened this issue Jun 15, 2020 · 7 comments · Fixed by #2385
Closed

Upgrade k8s client API to 1.18+ #1949

josephglanville opened this issue Jun 15, 2020 · 7 comments · Fixed by #2385
Assignees
@ukclivecox
Labels
priority/p1
Projects
1.3
Milestone
1.3

Comments

@josephglanville
Copy link

Multiple dependencies will shortly necessitate moving to k8s v1.18+ client libraries. This is a breaking change due to introduction of context on most of the API surface for creating resources and such. Istio is the main current feature that will require this upgrade to happen soon however Contour will need it too in order to update to the v1.5.0 client version.
@josephglanville josephglanville added the triage Needs to be triaged and prioritised accordingly label Jun 15, 2020
@ukclivecox
Copy link
Contributor

Hi @josephglanville We already have #1675 and #1678
Is this issue referring to further changes required? If so can you specify them?

@josephglanville
Copy link
Author

These may be related but I don't think address the actual k8s client-go upgrade and associated dependencies. All of these deps need to be updated in lockstep as I did for external-dns here kubernetes-sigs/external-dns#1627
This can be a pain and especially because upgrading Istio attempts to upgrade gRPC past 1.27 which is another breaking change.

@ukclivecox
Copy link
Contributor

Ok thanks. Will need to understand how this affects the executor and operator as we would want to support pre 1.18 k8s users given many clients are only on 1.14 at most.

@josephglanville
Copy link
Author

If I end up being the one to do it I will validate that anyway because our clusters are on v1.15. My understanding is the client is backwards compatible to all 1.X server/cluster versions however so I don't anticipate any issues.

@ukclivecox ukclivecox added this to the 1.3 milestone Jul 9, 2020
@ukclivecox ukclivecox added this to To do in 1.3 via automation Jul 9, 2020
@ukclivecox
Copy link
Contributor

Might be solved by #2088

@ukclivecox ukclivecox added priority/p1 and removed triage Needs to be triaged and prioritised accordingly labels Jul 9, 2020
@RafalSkolasinski
Copy link
Contributor

In #2088 we initially discussed bumping k8s.io deps to v0.17.8

@axsaucedo axsaucedo mentioned this issue Aug 13, 2020
Closed
@ukclivecox ukclivecox self-assigned this Aug 23, 2020
@ukclivecox ukclivecox moved this from To do to In progress in 1.3 Aug 27, 2020
@ukclivecox
Copy link
Contributor

See https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/20200123-client-go-ctx.md

@ukclivecox ukclivecox moved this from In progress to To do in 1.3 Sep 4, 2020
@ukclivecox ukclivecox mentioned this issue Sep 6, 2020
Merged
@ukclivecox ukclivecox moved this from To do to In Review in 1.3 Sep 6, 2020
1.3 automation moved this from In Review to Done Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ukclivecox ukclivecox

Labels
priority/p1
Projects
No open projects
1.3
  
Done
Milestone
1.3
Development

Successfully merging a pull request may close this issue.

Update k8s libs to 1.18.6
3 participants
@josephglanville @ukclivecox @RafalSkolasinski