Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies of Operator and Executor #2088

Closed
17 of 19 tasks
RafalSkolasinski opened this issue Jul 8, 2020 · 4 comments · Fixed by #2169
Closed
17 of 19 tasks

Update dependencies of Operator and Executor #2088

RafalSkolasinski opened this issue Jul 8, 2020 · 4 comments · Fixed by #2169
Assignees
Projects
Milestone

Comments

@RafalSkolasinski
Copy link
Contributor

RafalSkolasinski commented Jul 8, 2020

We should make sure that dependencies of Operator and Executor as as much up to date as it is possible.
Once we get both up-to-date we should keep it such using dependabot to avoid a big update in the future.

This will be a parent issue linking to smaller ones listed into a checklist:

Operator Upgrade

Executor Upgrade

Both

  • Verify that all direct dependencies are upgraded to reasonably recent versions
  • Verify possible issues with dependencies marked as incompatible

Dependabot Integration:

  • Operator
  • Executor

Update

  • We are note removing Executor's dependency on Operator refactoring logging to lift dependency controller-runtime is not crucial for this task
  • Instead of fixing Operator version in Executor update version of operator in executor deps #2121 will build Executor using Operator from monorepo (replace method in go.mod + symlinking operator folder)
  • go-logr package is interface definition and incompatibility seems to be present in our dependencies. As this is only interface definition updating it is not a priority for this issue

Attachments

Executor upgrade assessment

image

@RafalSkolasinski RafalSkolasinski added the triage Needs to be triaged and prioritised accordingly label Jul 8, 2020
@ukclivecox ukclivecox added priority/p1 and removed triage Needs to be triaged and prioritised accordingly labels Jul 9, 2020
@ukclivecox ukclivecox added this to To do in 1.3 via automation Jul 9, 2020
@ukclivecox ukclivecox added this to the 1.3 milestone Jul 9, 2020
@ukclivecox ukclivecox removed this from To do in 1.3 Jul 9, 2020
@ukclivecox ukclivecox added this to To do in 1.2.2 via automation Jul 9, 2020
@ukclivecox ukclivecox moved this from To do to In progress in 1.2.2 Jul 9, 2020
@RafalSkolasinski
Copy link
Contributor Author

Initial assessment for Operator

image

@ukclivecox ukclivecox added this to To do in 1.3 via automation Jul 9, 2020
@ukclivecox ukclivecox removed this from In progress in 1.2.2 Jul 9, 2020
@ukclivecox ukclivecox added this to To do in 1.2.2 via automation Jul 9, 2020
@ukclivecox ukclivecox removed this from To do in 1.3 Jul 9, 2020
@ukclivecox ukclivecox moved this from To do to In progress in 1.2.2 Jul 9, 2020
@RafalSkolasinski
Copy link
Contributor Author

+incomaptible comment in go.mods means incompatibility in different ways that Go uses to handle dependencies.

good read: https://stackoverflow.com/a/57372286/5420500

@RafalSkolasinski
Copy link
Contributor Author

RafalSkolasinski commented Jul 20, 2020

With 2nd level dependencies (and further) we have very limited control as this is basically set by 1st level dependencies.
We will need to raise issues directly in upstream projects in case there is an CVE or another important reason to upgrade arise.

1.2.2 automation moved this from Review in progress to Done Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
1.2.2
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants