Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Executor's dependency on client-go #2092

Closed
RafalSkolasinski opened this issue Jul 8, 2020 · 0 comments · Fixed by #2106
Closed

Remove Executor's dependency on client-go #2092

RafalSkolasinski opened this issue Jul 8, 2020 · 0 comments · Fixed by #2106
Labels
priority/p1
Projects
1.2.2
Milestone
1.3

Comments

@RafalSkolasinski
Copy link
Contributor

Sub Issue of #2088.

Client-go seems to be a historical dependency in Executor when SeldonDeployment CRD was requested by it using k8s API.
Right now it seems that Executor gets CRD through environmental variable.

This commit 3c0ed3d (from cruft branch) shows that removal is quite straightforward. Probably enough to cherry-pick this commit into a tiny PR.
@RafalSkolasinski RafalSkolasinski added the triage Needs to be triaged and prioritised accordingly label Jul 8, 2020
@RafalSkolasinski RafalSkolasinski mentioned this issue Jul 8, 2020
Closed
19 tasks
@axsaucedo axsaucedo added this to To do in 1.3 via automation Jul 8, 2020
@axsaucedo axsaucedo added this to the 1.3 milestone Jul 8, 2020
@ukclivecox ukclivecox added priority/p1 and removed triage Needs to be triaged and prioritised accordingly labels Jul 9, 2020
@ukclivecox ukclivecox added this to To do in 1.2.2 via automation Jul 9, 2020
@ukclivecox ukclivecox removed this from To do in 1.3 Jul 9, 2020
@ukclivecox ukclivecox moved this from To do to In progress in 1.2.2 Jul 9, 2020
@adriangonz adriangonz mentioned this issue Jul 10, 2020
Merged
@adriangonz adriangonz moved this from In progress to Review in progress in 1.2.2 Jul 10, 2020
1.2.2 automation moved this from Review in progress to Done Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/p1
Projects
No open projects
1.2.2
  
Done
Milestone
1.3
Development

Successfully merging a pull request may close this issue.

Remove executor's dependency on k8s.io/client-go adriangonz/seldon-core
3 participants
@axsaucedo @ukclivecox @RafalSkolasinski