Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transform_output_raw not working . It gets refered to transform-input endpoint when analysing logs #2277

Closed
divyadilip91 opened this issue Aug 14, 2020 · 10 comments
Labels
bug triage Needs to be triaged and prioritised accordingly

Comments

@divyadilip91
Copy link

divyadilip91 commented Aug 14, 2020

Hi,
I found an issue with transform_output_raw which did not seem to be working. I created a graph with a model and an output transformer and found that the ouptut from model (using predict_raw) was not passed to the transformer and in the logs I could see that "/transform-input" endpoint is being called instead of /transform-output
The seldon version I am using is 1.1.0.
Has this been fixed in the higher versions?
Expecting your reply

@divyadilip91 divyadilip91 added bug triage Needs to be triaged and prioritised accordingly labels Aug 14, 2020
@axsaucedo
Copy link
Contributor

Hi @divyadilip91, please fill out the template for bug creations in seldon, so we know exactly what image you used to wrap your model vs the image of the service orchestrator, as well as the yaml so we can reproduce. Thanks

@divyadilip91
Copy link
Author

divyadilip91 commented Aug 20, 2020

Hi @axsaucedo
Is there a service type OUTPUT_TRANSFORMER?I used TRANSFORMER as the service in my seldon graph for an outputtransformer component and not OUTPUT_TRANSFORMER. I didnt find a service of this type in the docs. Could the issue be because of this?

@divyadilip91
Copy link
Author

divyadilip91 commented Aug 20, 2020

@axsaucedo @RafalSkolasinski Hi . I am facing issue in creating the seldon graph too.. I am using seldon v1.1.0.
Could you help me in constructing the seldon graph for this diagram. Is it possible to pass the output of combiner to a model type service alone ?
image

#1927

@divyadilip91
Copy link
Author

divyadilip91 commented Aug 20, 2020

This is the graph I have created. But from the seldon docs and examples its unclear how to pass the combiner output to another node which can be a model or a transformer

image

@ukclivecox
Copy link
Contributor

This can be achieved by making your model3 an output-transformer so it runs after the combiner.

@divyadilip91
Copy link
Author

divyadilip91 commented Aug 20, 2020

This can be achieved by making your model3 an output-transformer so it runs after the combiner.

Hi @cliveseldon
So a combiner output can only be passed to an output transformer ?
I have my model3 already created as service type model and hence i want to reuse the container rather than creating model3 as an output transformer. If I have to rebuild the same model code as type output transformer, it looks as if I am not reusing my images. Is there any workaround for this?

@RafalSkolasinski
Copy link
Contributor

RafalSkolasinski commented Aug 21, 2020

Please try setting type: OUTPUT_TRANSFORMER - such node can be a parent of combiner and will be able to process its output

@divyadilip91
Copy link
Author

@RafalSkolasinski Thanks for your reply. So only an output transformer can be a parent of combiner?Could I connect the output from a combiner to be passed as input to another model/input transformer?

@RafalSkolasinski
Copy link
Contributor

As far as I am aware only the OUTPUT_TRANSFORMER node (and obviously the combiner) can process output of their children.

In other words, parents of COMBINER of different type (MODEL, TRANSFORMER, etc.) will received the request first before the COMBINER itself.

The difference of OUTPUT_TRANSFORMER is such that the request first goes to its children and then to the OUTPUT_TRANSFORMER.

For the diagram above you could try:

- name: output-transformer
  type: OUTPUT_TRANSFORMER
  children:
  - name: model-3
    type: OUTPUT_TRANSFORMER
    children:
    - name: combiner
      type: COMBINER
      children:
      - name: model-1
        type: MODEL
      - name: model-2
        type: MODEL

@divyadilip91
Copy link
Author

@divyadilip91 Ok got it. Thankyou for your response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug triage Needs to be triaged and prioritised accordingly
Projects
None yet
Development

No branches or pull requests

4 participants