Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integration tests fails: cannot import name 'Turkey' #2403

Closed
RafalSkolasinski opened this issue Sep 9, 2020 · 0 comments · Fixed by #2431
Closed

integration tests fails: cannot import name 'Turkey' #2403

RafalSkolasinski opened this issue Sep 9, 2020 · 0 comments · Fixed by #2431
Assignees
@RafalSkolasinski
Labels
bug
Projects
1.3
Milestone
1.3

Comments

@RafalSkolasinski
Copy link
Contributor

RafalSkolasinski commented Sep 9, 2020 •
edited
Loading

Error occurs when building alibi-detect-server.
It is caused by incompatibility in fbprophet and holidays versions.

Pinning them to

fbprophet==0.6
holidays==0.9.11

solves issue for now.

Update: instead of pinning fbprophet and holidays the related PR upgrades alibi-detect to version 0.4.2

Side note: we should upgrade alibi-detect once new one is released. Gonna open separate issue for this
@RafalSkolasinski RafalSkolasinski added bug triage Needs to be triaged and prioritised accordingly labels Sep 9, 2020
This was referenced Sep 9, 2020
Closed
Closed
@RafalSkolasinski RafalSkolasinski self-assigned this Sep 10, 2020
@RafalSkolasinski RafalSkolasinski added this to To do in 1.3 via automation Sep 10, 2020
@RafalSkolasinski RafalSkolasinski added this to the 1.3 milestone Sep 10, 2020
@ukclivecox ukclivecox moved this from To do to In Review in 1.3 Sep 10, 2020
@ukclivecox ukclivecox removed the triage Needs to be triaged and prioritised accordingly label Sep 10, 2020
This was referenced Sep 10, 2020
Closed
Merged
1.3 automation moved this from In Review to Done Sep 15, 2020
@RafalSkolasinski RafalSkolasinski mentioned this issue Sep 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RafalSkolasinski RafalSkolasinski

Labels
bug
Projects
No open projects
1.3
  
Done
Milestone
1.3
2 participants
@ukclivecox @RafalSkolasinski