-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade alibi-detect component to use alibi-detect 0.4.2 #2431
Upgrade alibi-detect component to use alibi-detect 0.4.2 #2431
Conversation
/test integration |
Mon Sep 14 10:44:21 UTC 2020 impatient try |
Mon Sep 14 10:44:34 UTC 2020 impatient try |
Mon Sep 14 10:46:49 UTC 2020 impatient try |
testing/scripts/kind_test_all.sh
Outdated
echo "Files changed in alibi explain folder:" | ||
git --no-pager diff --exit-code --name-only origin/master ../../components/alibi-explain-server/ | ||
ALIBI_MODIFIED=$? | ||
if [[ $ALIBI_MODIFIED -gt 0 ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should change this to ALIBI_EXPLAIN_MODIFIED and same below so they are separate (and then add them to the values at the bottom)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Mon Sep 14 17:48:24 UTC 2020 impatient try |
Mon Sep 14 17:48:24 UTC 2020 impatient try |
/approve |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Tue Sep 15 08:58:45 UTC 2020 impatient try |
Tue Sep 15 08:58:47 UTC 2020 impatient try |
What this PR does / why we need it:
Upgrades alibi-detect server to use
alibi-detect=0.4.2
.This is separate from #2404 to only include
alibi-detect
server changes.This also splits image build process to independently handle
alibi-explain
andalibi-detect
servers.Which issue(s) this PR fixes:
Closes #2403
Special notes for your reviewer:
Does this PR introduce a user-facing change?: