Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade alibi-detect component to use alibi-detect 0.4.2 #2431

Merged

Conversation

RafalSkolasinski
Copy link
Contributor

@RafalSkolasinski RafalSkolasinski commented Sep 14, 2020

What this PR does / why we need it:

Upgrades alibi-detect server to use alibi-detect=0.4.2.

This is separate from #2404 to only include alibi-detect server changes.

This also splits image build process to independently handle alibi-explain and alibi-detect servers.

Which issue(s) this PR fixes:

Closes #2403

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

updates alibi-detect to version 0.4.2

@RafalSkolasinski RafalSkolasinski changed the title Issue/2403/only turkey problem Upgrade alibi-detect component to use alibi 0.4.2 Sep 14, 2020
@RafalSkolasinski RafalSkolasinski changed the title Upgrade alibi-detect component to use alibi 0.4.2 Upgrade alibi-detect component to use alibi-detect 0.4.2 Sep 14, 2020
@RafalSkolasinski
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Mon Sep 14 10:44:21 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2431/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2431 --build=2

@seldondev
Copy link
Collaborator

Mon Sep 14 10:44:34 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2431/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2431 --build=1

@seldondev
Copy link
Collaborator

Mon Sep 14 10:46:49 UTC 2020
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2431/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2431 --build=3

echo "Files changed in alibi explain folder:"
git --no-pager diff --exit-code --name-only origin/master ../../components/alibi-explain-server/
ALIBI_MODIFIED=$?
if [[ $ALIBI_MODIFIED -gt 0 ]]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should change this to ALIBI_EXPLAIN_MODIFIED and same below so they are separate (and then add them to the values at the bottom)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@seldondev
Copy link
Collaborator

Mon Sep 14 17:48:24 UTC 2020
The logs for [pr-build] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2431/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2431 --build=4

@seldondev
Copy link
Collaborator

Mon Sep 14 17:48:24 UTC 2020
The logs for [lint] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2431/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2431 --build=5

@axsaucedo
Copy link
Contributor

/approve

@axsaucedo
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Tue Sep 15 08:58:45 UTC 2020
The logs for [lint] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2431/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2431 --build=7

@seldondev
Copy link
Collaborator

Tue Sep 15 08:58:47 UTC 2020
The logs for [pr-build] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2431/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2431 --build=6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

integration tests fails: cannot import name 'Turkey'
3 participants