Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prediction API get model version #244

Closed
jamborta opened this issue Oct 2, 2018 · 9 comments · Fixed by #246
Closed

Prediction API get model version #244

jamborta opened this issue Oct 2, 2018 · 9 comments · Fixed by #246

Comments

@jamborta
Copy link

jamborta commented Oct 2, 2018

I have a single model deployment which I am planning to update occasionally. Just wondering if there is a way for the prediction API to return the model version that it is currently serving, as it can be ambiguous during a rolling update. Currently it only returns an empty header:

'meta': {'puid': 'lt91ru9u5f8j8530m9dl40rrqo', 'tags': {}, 'routing': {}}}

@ukclivecox
Copy link
Contributor

We certainly want to add a set of default fields taken from the resource definition such as image name and version. This work we need feedback on what people want by default.

The wrappers at present focus on allowing the user to just return the predictions but we need to make it easy to pass back arbitrary meta data.

Perhaps we can use this issue as a basis for what we would like to see.

@jamborta
Copy link
Author

jamborta commented Oct 2, 2018

Image name and version would be sufficient for me.

@ukclivecox
Copy link
Contributor

If you could test with 0.2.4-SNAPSHOT images? @jamborta
See the Pull request #246 for details.

@jamborta
Copy link
Author

jamborta commented Oct 8, 2018

Great! Thank you.

@jamborta
Copy link
Author

jamborta commented Oct 15, 2018

@cliveseldon trying to test this, I'm using the image seldonio/seldon-core-s2i-python3:0.3-SNAPSHOT but getting the old format. It is set to REST.

@ukclivecox
Copy link
Contributor

You need to use images from 0.2.4-SNAPSHOT when installing seldon-core. Can you check you are using these. And you have redownloaded if so as they are SNAPSHOT images and recreated periodically.

@jamborta
Copy link
Author

@cliveseldon This was working last week, but today I reinstalled seldon-core-0.2.4-SNAPSHOT, but it is returning the old format.

@ukclivecox
Copy link
Contributor

OK, that's strange. Running the latest helm examples should give you an example output like below:

helm-example

Can you tell us more about how you are testing so we can try to dig deeper?

@ukclivecox ukclivecox reopened this Oct 29, 2018
@jamborta
Copy link
Author

@cliveseldon sorry, just realised that it picked up some old jar file from cache when installed. Works ok now.

agrski pushed a commit that referenced this issue Dec 2, 2022
* make secret optional

* make bucket name configurable

* initial structure

* Metrics docs

* add example dashboard

* add a list of tests

* performance tests

* add more docs

* add a note about custom k6 image building
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants