Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2 notebook tests failing #2454

Closed
RafalSkolasinski opened this issue Sep 18, 2020 · 0 comments · Fixed by #2453
Closed

2 notebook tests failing #2454

RafalSkolasinski opened this issue Sep 18, 2020 · 0 comments · Fixed by #2453
Assignees
@RafalSkolasinski
Labels
bug
Milestone
1.3

Comments

@RafalSkolasinski
Copy link
Contributor

Following two notebook tests are failing:

  • TestNotebooks.test_grpc_metadata
  • TestNotebooks.test_explainer_examples

First one is missing transport: grpc to adjust to reverting multiplexing in executor.
Second one is failing because jq is missing in the the core-builder image.
@RafalSkolasinski RafalSkolasinski added bug triage Needs to be triaged and prioritised accordingly labels Sep 18, 2020
@RafalSkolasinski RafalSkolasinski mentioned this issue Sep 18, 2020
Merged
@RafalSkolasinski RafalSkolasinski self-assigned this Sep 18, 2020
@RafalSkolasinski RafalSkolasinski added this to the 1.3 milestone Sep 18, 2020
@RafalSkolasinski RafalSkolasinski removed the triage Needs to be triaged and prioritised accordingly label Sep 18, 2020
@RafalSkolasinski RafalSkolasinski mentioned this issue Sep 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RafalSkolasinski RafalSkolasinski

Labels
bug
Projects
None yet
Milestone
1.3
Development

Successfully merging a pull request may close this issue.

upgrade core-builder to 0.18 and fix last 2 failing notebook tests
1 participant
@RafalSkolasinski