Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new knative filtering #2551

Closed
ryandawsonuk opened this issue Oct 15, 2020 · 2 comments · Fixed by #2626
Closed

new knative filtering #2551

ryandawsonuk opened this issue Oct 15, 2020 · 2 comments · Fixed by #2626
Assignees
Projects
Milestone

Comments

@ryandawsonuk
Copy link
Contributor

We're using sourceAndType filters but they were deprecated and have now been removed. Seems like the new way is more powerful

@ukclivecox ukclivecox added this to To do in 1.5 via automation Oct 15, 2020
@ukclivecox ukclivecox added this to the 1.5 milestone Oct 15, 2020
@ukclivecox ukclivecox self-assigned this Oct 15, 2020
@ryandawsonuk
Copy link
Contributor Author

ryandawsonuk commented Oct 16, 2020

The minimum to do this would just be to update knative version, change v1alpha1 to v1 and change

  filter:
    sourceAndType:
      type: io.seldon.serving.inference.request

to

  filter:
    attributes:
      type: io.seldon.serving.inference.request

But it seems there's also potential to add extra custom attributes so that we could filter by attributes such as which model the event is for.

Also affects kfserving

@ryandawsonuk
Copy link
Contributor Author

Looks like we could use multiple filters so that an outlier detector trigger could be filtered to just requests for a particular model

@ukclivecox ukclivecox moved this from To do to In progress in 1.5 Nov 9, 2020
@ukclivecox ukclivecox moved this from In progress to In Review in 1.5 Nov 11, 2020
1.5 automation moved this from In Review to Done Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
1.5
Done
Development

Successfully merging a pull request may close this issue.

2 participants