Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Alibi-Detect wrapper and drift and outlier examples #2626

Merged
merged 4 commits into from
Nov 13, 2020
Merged

Update Alibi-Detect wrapper and drift and outlier examples #2626

merged 4 commits into from
Nov 13, 2020

Conversation

ukclivecox
Copy link
Contributor

What this PR does / why we need it:

  • Update Alibi detect wrapper
    • Ensures cloud events v1 used
    • Fixes Dockerfile USER
  • Update drift and outlier examples for knative 0.18 and istio 1.7

Which issue(s) this PR fixes:

Fixes #2551

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@seldondev
Copy link
Collaborator

Wed Nov 11 15:00:48 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2626/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2626 --build=1

@seldondev
Copy link
Collaborator

Wed Nov 11 15:00:53 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2626/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2626 --build=2

@seldondev
Copy link
Collaborator

Wed Nov 11 15:03:07 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2626/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2626 --build=4

@seldondev
Copy link
Collaborator

Wed Nov 11 15:03:56 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2626/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2626 --build=3

@@ -37,9 +37,17 @@
},
{
"cell_type": "code",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice this notebook still says "Tested on GKE with Knative 0.13 and Istio 1.3.1". We should change that to 0.18 and 1.7

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@seldondev
Copy link
Collaborator

Fri Nov 13 08:33:58 UTC 2020
The logs for [pr-build] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2626/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2626 --build=7

@seldondev
Copy link
Collaborator

Fri Nov 13 08:34:05 UTC 2020
The logs for [lint] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2626/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2626 --build=8

Copy link
Contributor

@ryandawsonuk ryandawsonuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@axsaucedo
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo, ryandawsonuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [axsaucedo,ryandawsonuk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Fri Nov 13 17:20:43 UTC 2020
The logs for [pr-build] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2626/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2626 --build=9

@seldondev
Copy link
Collaborator

Fri Nov 13 17:20:57 UTC 2020
The logs for [lint] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2626/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2626 --build=10

@axsaucedo axsaucedo merged commit 125373b into SeldonIO:master Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new knative filtering
4 participants