Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEDA prom auto scale notebook is broken #2563

Closed
anggao opened this issue Oct 21, 2020 · 0 comments · Fixed by #2565
Closed

KEDA prom auto scale notebook is broken #2563

anggao opened this issue Oct 21, 2020 · 0 comments · Fixed by #2565
Labels
Projects
Milestone

Comments

@anggao
Copy link
Contributor

anggao commented Oct 21, 2020

Describe the bug

The notebook testing keda_prom_auto_scale.ipynb is broken

To reproduce

make test_notebooks

Expected behaviour

Pass test

Environment

master branch

Model Details

  • Images of your model: [Output of: kubectl get seldondeployment -n <yourmodelnamespace> <seldondepname> -o yaml | grep image: where <yourmodelnamespace>]
  • Logs of your model: [You can get the logs of your model by running kubectl logs -n <yourmodelnamespace> <seldonpodname> <container>]
@anggao anggao added bug triage Needs to be triaged and prioritised accordingly labels Oct 21, 2020
@ukclivecox ukclivecox removed the triage Needs to be triaged and prioritised accordingly label Oct 22, 2020
@ukclivecox ukclivecox added this to the 1.4 milestone Oct 22, 2020
@ukclivecox ukclivecox added this to To do in 1.4 via automation Oct 22, 2020
@ukclivecox ukclivecox moved this from To do to In Review in 1.4 Oct 22, 2020
1.4 automation moved this from In Review to Done Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
1.4
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants