Fix keda notebook testing #2565

anggao · 2020-10-21T14:19:22Z

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

seldondev · 2020-10-21T14:19:25Z

Hi @anggao. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

review-notebook-app · 2020-10-21T14:19:26Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

anggao · 2020-10-21T14:31:03Z

@cliveseldon @RafalSkolasinski FYI

RafalSkolasinski · 2020-10-21T14:34:07Z

Thanks @anggao!
/test notebooks

RafalSkolasinski · 2020-10-21T14:34:21Z

/test integration

seldondev · 2020-10-21T14:35:36Z

Wed Oct 21 14:35:35 UTC 2020
The logs for [notebooks] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2565/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2565 --build=1

seldondev · 2020-10-21T14:35:59Z

Wed Oct 21 14:35:58 UTC 2020
The logs for [integration] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2565/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2565 --build=2

anggao · 2020-10-21T14:59:55Z

/test lint

seldondev · 2020-10-21T14:59:58Z

@anggao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

anggao · 2020-10-21T15:00:19Z

@RafalSkolasinski can you add /ok-to-test for me :)

RafalSkolasinski · 2020-10-21T15:00:50Z

/ok-to-test

seldondev · 2020-10-21T15:16:38Z

Wed Oct 21 15:16:37 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2565/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2565 --build=4

seldondev · 2020-10-21T15:16:49Z

Wed Oct 21 15:16:48 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2565/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2565 --build=3

anggao · 2020-10-21T17:00:55Z

/retest

seldondev · 2020-10-21T17:02:41Z

Wed Oct 21 17:02:40 UTC 2020
The logs for [integration] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2565/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2565 --build=6

seldondev · 2020-10-21T17:02:46Z

Wed Oct 21 17:02:45 UTC 2020
The logs for [notebooks] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2565/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2565 --build=5

anggao · 2020-10-21T23:32:22Z

I found
test_keda_prom_auto_scale passed 1 out of the required 1 times. Success!

Looks like the failure just because flaky tests ?

helm-charts/seldon-core-operator/templates/clusterrole_seldon-manager-role.yaml

RafalSkolasinski · 2020-10-22T09:55:52Z

I found
test_keda_prom_auto_scale passed 1 out of the required 1 times. Success!

Looks like the failure just because flaky tests ?

I am afraid not, the integration tests started failing and they were fine before :(

Currently we know about three other notebook tests failing:

custom_metrics
protocol_examples
explainer_examples

everything else should be green

anggao · 2020-10-22T10:56:25Z

@RafalSkolasinski hum... I will take a look

anggao · 2020-10-22T10:56:42Z

/retest

seldondev · 2020-10-22T10:58:10Z

Thu Oct 22 10:58:07 UTC 2020
The logs for [integration] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2565/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2565 --build=8

seldondev · 2020-10-22T10:58:19Z

Thu Oct 22 10:58:18 UTC 2020
The logs for [notebooks] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2565/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2565 --build=7

ukclivecox · 2020-10-22T13:35:33Z

/test integration

seldondev · 2020-10-22T13:37:02Z

Thu Oct 22 13:37:02 UTC 2020
The logs for [integration] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2565/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2565 --build=9

seldondev · 2020-10-22T14:34:40Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign cliveseldon
You can assign the PR to them by writing /assign @cliveseldon in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

anggao · 2020-10-22T14:34:50Z

/test integration

anggao · 2020-10-22T14:35:10Z

/test notebooks

seldondev · 2020-10-22T14:35:44Z

Thu Oct 22 14:35:43 UTC 2020
The logs for [lint] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2565/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2565 --build=11

seldondev · 2020-10-22T14:35:52Z

Thu Oct 22 14:35:46 UTC 2020
The logs for [pr-build] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2565/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2565 --build=10

seldondev · 2020-10-22T14:36:09Z

Thu Oct 22 14:36:08 UTC 2020
The logs for [integration] [12] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2565/12.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2565 --build=12

seldondev · 2020-10-22T14:36:47Z

Thu Oct 22 14:36:46 UTC 2020
The logs for [notebooks] [13] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2565/13.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2565 --build=13

anggao · 2020-10-22T16:40:34Z

/retest

seldondev · 2020-10-22T16:41:55Z

Thu Oct 22 16:41:54 UTC 2020
The logs for [lint] [15] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2565/15.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2565 --build=15

seldondev · 2020-10-22T16:41:58Z

Thu Oct 22 16:41:58 UTC 2020
The logs for [pr-build] [14] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2565/14.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2565 --build=14

anggao · 2020-10-22T16:42:37Z

/test integration

anggao · 2020-10-22T16:42:45Z

/test notebooks

seldondev · 2020-10-22T16:45:34Z

Thu Oct 22 16:45:33 UTC 2020
The logs for [integration] [16] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2565/16.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2565 --build=16

seldondev · 2020-10-22T16:45:45Z

Thu Oct 22 16:45:43 UTC 2020
The logs for [notebooks] [17] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2565/17.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2565 --build=17

seldondev · 2020-10-22T20:02:03Z

@anggao: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
notebooks	`7c93b2a`	link	`/test notebooks`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

anggao · 2020-10-22T20:06:51Z

Looks like only known notebook issue left: explainer_examples

axsaucedo · 2020-10-22T20:13:40Z

Awesome @anggao! This looks great - almost all green ticks! After this and Clive's prs are merged we'll be back to green ticks for all tests 🚀

Fix keda notebook testing

076de8f

seldondev added the needs-ok-to-test label Oct 21, 2020

seldondev added the size/XXL label Oct 21, 2020

anggao added 2 commits October 21, 2020 15:27

add text to remind enabling keda support in the operator

01fc638

update licenses file

143376c

seldondev added ok-to-test and removed needs-ok-to-test labels Oct 21, 2020

ukclivecox added this to In progress in 1.4 via automation Oct 22, 2020

ukclivecox added this to the 1.4 milestone Oct 22, 2020

ukclivecox suggested changes Oct 22, 2020

View reviewed changes

helm-charts/seldon-core-operator/templates/clusterrole_seldon-manager-role.yaml Show resolved Hide resolved

seldondev assigned ukclivecox Oct 22, 2020

ukclivecox moved this from In progress to In Review in 1.4 Oct 22, 2020

ukclivecox removed this from In Review in 1.4 Oct 22, 2020

add KEDA in the testing environment

73ef934

fix Makefile format

7c93b2a

ukclivecox merged commit 9da1f5e into SeldonIO:master Oct 23, 2020

Fix keda notebook testing #2565

Fix keda notebook testing #2565

Conversation

anggao commented Oct 21, 2020

seldondev commented Oct 21, 2020

review-notebook-app bot commented Oct 21, 2020

anggao commented Oct 21, 2020

RafalSkolasinski commented Oct 21, 2020

RafalSkolasinski commented Oct 21, 2020

seldondev commented Oct 21, 2020

seldondev commented Oct 21, 2020

anggao commented Oct 21, 2020

seldondev commented Oct 21, 2020

anggao commented Oct 21, 2020

RafalSkolasinski commented Oct 21, 2020

seldondev commented Oct 21, 2020

seldondev commented Oct 21, 2020

anggao commented Oct 21, 2020

seldondev commented Oct 21, 2020

seldondev commented Oct 21, 2020

anggao commented Oct 21, 2020

RafalSkolasinski commented Oct 22, 2020 • edited Loading

anggao commented Oct 22, 2020

anggao commented Oct 22, 2020

seldondev commented Oct 22, 2020

seldondev commented Oct 22, 2020

ukclivecox commented Oct 22, 2020

seldondev commented Oct 22, 2020

seldondev commented Oct 22, 2020

anggao commented Oct 22, 2020

anggao commented Oct 22, 2020

seldondev commented Oct 22, 2020

seldondev commented Oct 22, 2020

seldondev commented Oct 22, 2020

seldondev commented Oct 22, 2020

anggao commented Oct 22, 2020

seldondev commented Oct 22, 2020

seldondev commented Oct 22, 2020

anggao commented Oct 22, 2020

anggao commented Oct 22, 2020

seldondev commented Oct 22, 2020

seldondev commented Oct 22, 2020

seldondev commented Oct 22, 2020

anggao commented Oct 22, 2020

axsaucedo commented Oct 22, 2020

RafalSkolasinski commented Oct 22, 2020 •

edited

Loading