Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add namespace to metrics component in seldon core python module #2666

Closed
axsaucedo opened this issue Nov 19, 2020 · 1 comment
Closed

Add namespace to metrics component in seldon core python module #2666

axsaucedo opened this issue Nov 19, 2020 · 1 comment
Assignees
@axsaucedo
Labels
triage Needs to be triaged and prioritised accordingly
Projects
1.5

Comments

@axsaucedo
Copy link
Contributor

Currently the seldon metrics module does not provide a way to expose the namespace of where the metric comes from. This would be important to be set, and could be done by introducing the SELDON_DEPLOYMENT_NAMESPACE . This would not be possible to use just the kubernetes variable as for the case of the outlier detector, this would be on a different namespace of the model.
@axsaucedo axsaucedo added the triage Needs to be triaged and prioritised accordingly label Nov 19, 2020
@axsaucedo axsaucedo self-assigned this Nov 19, 2020
@axsaucedo axsaucedo added this to To do in 1.5 via automation Nov 19, 2020
@axsaucedo axsaucedo mentioned this issue Nov 19, 2020
Merged
2 tasks
@axsaucedo
Copy link
Contributor Author

Fixed by #2672 but decided only for alibi detec server

1.5 automation moved this from To do to Done Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@axsaucedo axsaucedo

Labels
triage Needs to be triaged and prioritised accordingly
Projects
No open projects
1.5
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@axsaucedo