Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alibi detect enhancements (Expose metrics with 0 value and include seldon_deployment_namespace tag to metric) #2672

Merged
merged 5 commits into from
Nov 19, 2020

Conversation

axsaucedo
Copy link
Contributor

@axsaucedo axsaucedo commented Nov 19, 2020

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign axsaucedo
You can assign the PR to them by writing /assign @axsaucedo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Thu Nov 19 14:56:35 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2672/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2672 --build=1

@seldondev
Copy link
Collaborator

Thu Nov 19 14:56:44 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2672/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2672 --build=2

@seldondev
Copy link
Collaborator

Thu Nov 19 15:04:00 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2672/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2672 --build=3

@seldondev
Copy link
Collaborator

Thu Nov 19 15:04:15 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2672/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2672 --build=4

@seldondev
Copy link
Collaborator

Thu Nov 19 15:08:34 UTC 2020
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2672/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2672 --build=5

@seldondev
Copy link
Collaborator

Thu Nov 19 15:08:41 UTC 2020
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2672/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2672 --build=6

@seldondev
Copy link
Collaborator

Thu Nov 19 15:24:03 UTC 2020
The logs for [pr-build] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2672/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2672 --build=7

@seldondev
Copy link
Collaborator

Thu Nov 19 15:24:08 UTC 2020
The logs for [lint] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2672/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2672 --build=8

@seldondev
Copy link
Collaborator

Thu Nov 19 16:04:42 UTC 2020
The logs for [lint] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2672/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2672 --build=10

@seldondev
Copy link
Collaborator

Thu Nov 19 16:04:43 UTC 2020
The logs for [pr-build] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2672/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2672 --build=9

@axsaucedo axsaucedo changed the title WIP: Alibi detect enhancements Alibi detect enhancements (Expose metrics with 0 value and include seldon_deployment_namespace tag to metric) Nov 19, 2020
Copy link
Contributor

@SachinVarghese SachinVarghese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@axsaucedo axsaucedo merged commit e3aea47 into SeldonIO:master Nov 19, 2020
@@ -27,6 +27,12 @@
CESERVER_LOGLEVEL = os.environ.get("CESERVER_LOGLEVEL", "INFO").upper()
logging.basicConfig(level=CESERVER_LOGLEVEL)

DEFAULT_LABELS = {
"seldon_deployment_namespace": os.environ.get(
"SELDON_DEPLYOMENT_NAMESPACE", "NOT_IMPLEMENTED"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @axsaucedo missed a typo here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants