-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alibi detect enhancements (Expose metrics with 0 value and include seldon_deployment_namespace tag to metric) #2672
Alibi detect enhancements (Expose metrics with 0 value and include seldon_deployment_namespace tag to metric) #2672
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thu Nov 19 14:56:35 UTC 2020 impatient try |
Thu Nov 19 14:56:44 UTC 2020 impatient try |
Thu Nov 19 15:04:00 UTC 2020 impatient try |
Thu Nov 19 15:04:15 UTC 2020 impatient try |
ef30854
to
ec7eb97
Compare
Thu Nov 19 15:08:34 UTC 2020 impatient try |
Thu Nov 19 15:08:41 UTC 2020 impatient try |
Thu Nov 19 15:24:03 UTC 2020 impatient try |
Thu Nov 19 15:24:08 UTC 2020 impatient try |
Thu Nov 19 16:04:42 UTC 2020 impatient try |
Thu Nov 19 16:04:43 UTC 2020 impatient try |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@@ -27,6 +27,12 @@ | |||
CESERVER_LOGLEVEL = os.environ.get("CESERVER_LOGLEVEL", "INFO").upper() | |||
logging.basicConfig(level=CESERVER_LOGLEVEL) | |||
|
|||
DEFAULT_LABELS = { | |||
"seldon_deployment_namespace": os.environ.get( | |||
"SELDON_DEPLYOMENT_NAMESPACE", "NOT_IMPLEMENTED" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @axsaucedo missed a typo here
Fixes: