Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve labelling inconsistencies on seldon-managed k8s resources #2757

Closed
SachinVarghese opened this issue Dec 10, 2020 — with Board Genius Sync · 0 comments · Fixed by #3123
Closed

Improve labelling inconsistencies on seldon-managed k8s resources #2757

SachinVarghese opened this issue Dec 10, 2020 — with Board Genius Sync · 0 comments · Fixed by #3123
Assignees
@ukclivecox
Labels
enhancement

Comments

@SachinVarghese Board Genius Sync
Copy link
Contributor

Predictor level services missing seldon-app label. Example list of labels

app.kubernetes.io/managed-by=seldon-core     
seldon-app-svc=cifar10-default-cifar10-container               
seldon-deployment-id=cifar10                                
seldon.io/default=true       
seldon.io/model=true

Explainer labels incorrect for seldon-app

app.kubernetes.io/managed-by=seldon-core              
seldon-app=cifar10-default-explainer             
seldon-deployment-id=cifar10                                   
seldon.io/default=true         
seldon.io/explainer=true

Here, seldon-app label is cifar10-default-explainer instead of cifar10-default.
@SachinVarghese SachinVarghese added enhancement triage Needs to be triaged and prioritised accordingly labels Dec 10, 2020
@SachinVarghese SachinVarghese added this to the 1.6 milestone Dec 10, 2020
@SachinVarghese SachinVarghese added triage Needs to be triaged and prioritised accordingly and removed triage Needs to be triaged and prioritised accordingly labels Dec 10, 2020
@ukclivecox ukclivecox self-assigned this Dec 10, 2020
@ukclivecox ukclivecox removed the triage Needs to be triaged and prioritised accordingly label Dec 10, 2020
@ukclivecox ukclivecox removed this from the 1.6 milestone Mar 4, 2021
@ukclivecox ukclivecox changed the title Imporve labelling inconsistencies on seldon-managed k8s resources Improve labelling inconsistencies on seldon-managed k8s resources Mar 8, 2021
@ukclivecox ukclivecox mentioned this issue Apr 15, 2021
Merged
@axsaucedo axsaucedo changed the title Improve labelling inconsistencies on seldon-managed k8s resources OSS-178: Improve labelling inconsistencies on seldon-managed k8s resources Apr 26, 2021
@axsaucedo axsaucedo changed the title OSS-178: Improve labelling inconsistencies on seldon-managed k8s resources Improve labelling inconsistencies on seldon-managed k8s resources Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ukclivecox ukclivecox

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add label to container services for graph internal nodes
2 participants
@ukclivecox @SachinVarghese