Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misaligned documentation for SKLearn pre-packaged model server #3029

Closed
Roymprog opened this issue Mar 8, 2021 · 1 comment · Fixed by #3030
Closed

Misaligned documentation for SKLearn pre-packaged model server #3029

Roymprog opened this issue Mar 8, 2021 · 1 comment · Fixed by #3030
Labels
bug triage Needs to be triaged and prioritised accordingly

Comments

@Roymprog
Copy link

Roymprog commented Mar 8, 2021

I was reading through the documentation on pre-packaged model servers for SKLearn. The quickstart guide uses a model.pickle as name the serialized model using the SKLearn model server, but the detailed SKLearn model server documentation explicitly states one should use model.joblib.

The truth appears to be model.joblib, hence the quickstart documentation should be updated.

@Roymprog Roymprog added bug triage Needs to be triaged and prioritised accordingly labels Mar 8, 2021
@axsaucedo
Copy link
Contributor

Good shout @Roymprog ! Yes we should fix this - would you be able to add a small PR with fix? Otherwise we'll be able to address, let us know and we can proceed accordingly

axsaucedo added a commit that referenced this issue Mar 8, 2021
@axsaucedo axsaucedo mentioned this issue Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug triage Needs to be triaged and prioritised accordingly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants