Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SA name hardcoded in seldon-leader-election-role rbac #3168

Closed
samldd opened this issue May 6, 2021 · 0 comments · Fixed by #3200
Closed

SA name hardcoded in seldon-leader-election-role rbac #3168

samldd opened this issue May 6, 2021 · 0 comments · Fixed by #3200
Assignees
Labels

Comments

@samldd
Copy link

samldd commented May 6, 2021

The Seldon helm chart provide you with the option of defining your own service account to attach to the Seldon resources. If RBAC is enabled it also attaches different roles necessary for Seldon components to this SA. Compared to the other roleBindings in the helm chart, the one for seldon-leader-election-role has the service account hard coded:

roleRef:
  apiGroup: rbac.authorization.k8s.io
  kind: Role
  name: seldon-leader-election-role
subjects:
- kind: ServiceAccount
  name: seldon-manager
  namespace: '{{ include "seldon.namespace" . }}'

The name should be: '{{ .Values.serviceAccount.name}}'

@samldd samldd added bug triage Needs to be triaged and prioritised accordingly labels May 6, 2021
@ukclivecox ukclivecox removed the triage Needs to be triaged and prioritised accordingly label May 17, 2021
@ukclivecox ukclivecox self-assigned this May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants