Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python Wrappers Version 2 #406

Closed
ukclivecox opened this issue Jan 25, 2019 · 1 comment
Closed

Python Wrappers Version 2 #406

ukclivecox opened this issue Jan 25, 2019 · 1 comment
Assignees
Projects
Milestone

Comments

@ukclivecox
Copy link
Contributor

We should update the Python wrapper to add more streamlined code paths.

  • For REST requests always parse into proto buffers and have a central shared processing step that is general to gRPC and REST and works on the proto buffers.
  • Convert the various components - models, transformers, routers etc to use a single code base as there is a lot of shared code.

This work could be Python 3 specific and add in some of the tasks such as #392

@jklaise
Copy link
Member

jklaise commented Jan 25, 2019

Closely related we should have a think about function signatures for components written in Python. It makes sense to keep these clean and data-science focused (e.g. predict should take features X directly rather than the full SeldonMessage request) at the cost of us doing the SeldonMessage parsing when they enter and exit the component in the wrappers, but the user might want more flexibility (e.g. #407 where they might want access to the SeldonMessage metadata from within the component).

EDIT: I forgot we already have the functionality of working with raw SeldonMessages via defining low-level *_rest and *_grpc methods in the components, e.g.:

if hasattr(user_model, "predict_rest"):
)

@ukclivecox ukclivecox added this to the 0.3.x milestone Jan 27, 2019
@jklaise jklaise added this to To do in 0.2.6 Jan 31, 2019
@ukclivecox ukclivecox moved this from To do to In progress in 0.2.6 Feb 17, 2019
@ukclivecox ukclivecox removed this from In progress in 0.2.6 Feb 18, 2019
@ukclivecox ukclivecox added this to In progress in 0.2.7 Feb 21, 2019
@ukclivecox ukclivecox self-assigned this Feb 21, 2019
@ukclivecox ukclivecox moved this from In progress to Done in 0.2.7 Mar 6, 2019
agrski added a commit that referenced this issue Dec 2, 2022
* Add extension method to set number of KStream threads in pipeline config

* Add method to calc num KStream threads from pipeline size

* Set number of KStream threads per pipeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
0.2.7
  
Done
Development

No branches or pull requests

2 participants