Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Class names in latest python library is not backwards compatible #462

Closed
ukclivecox opened this issue Mar 8, 2019 · 0 comments · Fixed by #502
Closed

Class names in latest python library is not backwards compatible #462

ukclivecox opened this issue Mar 8, 2019 · 0 comments · Fixed by #502
Assignees
@ukclivecox
Labels
Python
Projects
0.2.7
Milestone
0.2.x

Comments

@ukclivecox
Copy link
Contributor

The current master version of the python module has class_names in the user model as a method while previous version had it as an attribute. Update library to be backwards compatible and output warning for deprecation.
@ukclivecox ukclivecox added this to the 0.2.x milestone Mar 8, 2019
@ukclivecox ukclivecox self-assigned this Mar 8, 2019
@ukclivecox ukclivecox added this to In progress in 0.2.7 Apr 10, 2019
@ukclivecox ukclivecox mentioned this issue Apr 10, 2019
Merged
@ukclivecox ukclivecox moved this from In progress to Done in 0.2.7 Apr 10, 2019
agrski added a commit that referenced this issue Dec 2, 2022
@agrski
Fix missing pipeline ID in data-flow engine consumer groups (#462)
895a208 
* Set KafkaStreams app ID on new object in extension method
    
There was a bug here: the method returns a new object to avoid mutating the old one,
but in fact set new parameters in the old object rather than the new one!
This was a simple typo with big implications for how different data flow
engines interact and process topics handed to them specifically by the scheduler.

* Remove unnecessary Kafka config
    
The Streams config handles consumer groups via the application ID,
thus does not need to be set independently (and may even be ignored).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ukclivecox ukclivecox

Labels
Python
Projects
No open projects
0.2.7
  
Done
Milestone
0.2.x
Development

Successfully merging a pull request may close this issue.

Allow class_names as method or attribute (deprecated) in Python module
1 participant
@ukclivecox