Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs do not mention addition of jsonData outside of the release notes #652

Closed
colebaileygit opened this issue Jun 26, 2019 · 3 comments
Closed
Assignees
Projects

Comments

@colebaileygit
Copy link

I wasn't aware of the jsonData support even after going through most of the docs and several examples until someone mentioned it on Slack - actually that was a use-case I was considering building my own work-around for.

I think this section of the docs should be updated to reflect this: https://docs.seldon.io/projects/seldon-core/en/latest/reference/apis/prediction.html

Perhaps also an example or snippet showing how the user-defined function signature works with dictionary data could be added.

@ukclivecox ukclivecox added this to To do in 0.4.0 via automation Jun 26, 2019
@ryandawsonuk
Copy link
Contributor

@colebaileygit if you're interested in submitting a PR you can modify that docs page at https://github.com/SeldonIO/seldon-core/blob/master/doc/source/reference/apis/prediction.md - you can even use the edit button direct from the github UI

@gsunner gsunner moved this from To do to In progress in 0.4.0 Jul 9, 2019
@gsunner
Copy link
Member

gsunner commented Jul 9, 2019

added scikit learn iris model using jsondata example PR #678

@gsunner
Copy link
Member

gsunner commented Aug 12, 2019

Proto doc updated in PR #786

@gsunner gsunner closed this as completed Aug 13, 2019
0.4.0 automation moved this from In progress to Done Aug 13, 2019
agrski pushed a commit that referenced this issue Dec 2, 2022
* tidy update scenarios

* fix scenario

* changes to k6 base
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
0.4.0
  
Done
Development

No branches or pull requests

3 participants