Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exception swallowing in seldon-core #725

Closed
ryandawsonuk opened this issue Jul 25, 2019 · 2 comments
Closed

exception swallowing in seldon-core #725

ryandawsonuk opened this issue Jul 25, 2019 · 2 comments
Assignees
@ukclivecox

Comments

@ryandawsonuk
Copy link
Contributor

e.g. https://github.com/SeldonIO/seldon-core/blob/master/python/seldon_core/user_model.py#L141

We were hitting this when having a sklearn version mismatch. The end result was that the model returned an empty message and didn't log any error.
@ryandawsonuk ryandawsonuk modified the milestone: 0.3.x Jul 25, 2019
@axsaucedo
Copy link
Contributor

This may be another place where #700 will have to be changed, as there are AttributeErrors that are being caught as well, which may not be just due to the Model wrapper not implementing a specific function.

@ukclivecox ukclivecox self-assigned this Jul 25, 2019
@ukclivecox
Copy link
Contributor

Duplicate #700

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ukclivecox ukclivecox

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@axsaucedo @ukclivecox @ryandawsonuk