Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can we expose health check api in internal python service similar to what we have in external like /ping #770

Closed
klalit opened this issue Aug 9, 2019 · 4 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Milestone

Comments

@klalit
Copy link
Contributor

klalit commented Aug 9, 2019

No description provided.

@ukclivecox
Copy link
Contributor

This would need a proposal to add a user provided or Python wrapper specific /ping endpoint and a convention for the engine to know to use this rather than the default TCP connect check to the exposed port. We need to bear in mind the engine needs to use this default readiness check as components can be built using any custom or supported way to create a container so at present we don't enforce a convention that all components must support a /ping or /ready endpoint. We could decide to do this but might be a post 1.0 decision?

@ukclivecox ukclivecox added this to the 1.0.x milestone Aug 24, 2019
@klalit
Copy link
Contributor Author

klalit commented Aug 26, 2019

yes... sounds good

@seldondev
Copy link
Collaborator

Issues go stale after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
/lifecycle stale

@seldondev seldondev added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 17, 2020
@ukclivecox
Copy link
Contributor

This is available now in 1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

3 participants