Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update transitive dependencies #1003

Merged
merged 4 commits into from Oct 31, 2019

Conversation

adriangonz
Copy link
Contributor

Fixes #1002.

Changelog

Notes

The latest version of proto-google-common-protos seems to be v1.17.0 according to Maven Repository. However, as it's pointed out in this issue grpc/grpc-java#6336, the https://github.com/googleapis/common-protos-java repo seems to be still pointing to v1.16.0. Therefore, it seems sensible to update to v1.16.0 until it's confirmed which one is the latest version.

@adriangonz
Copy link
Contributor Author

/uncc @jklaise

@seldondev seldondev removed the request for review from jklaise October 28, 2019 15:41
@adriangonz adriangonz self-assigned this Oct 28, 2019
@adriangonz
Copy link
Contributor Author

/cc @cliveseldon @gsunner

@axsaucedo
Copy link
Contributor

Looks solid! Did all the e2e tests run successfully?

@adriangonz
Copy link
Contributor Author

@axsaucedo Yuup, e2e tests seem to pass!

@axsaucedo
Copy link
Contributor

/lgtm

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ukclivecox ukclivecox merged commit 04d405d into SeldonIO:master Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update transitive dependencies
4 participants