Seldon Components Usage Examples

[gosandhya]

Adding two examples that illustrate how to use various seldon-core graph components for machine learning models:

1. uses Seldon Input_Transformer component for Spam Classification.
2. extends the previous example to add Combiner component.

[gosandhya]

Thank you for your contribution @SandhyaaGopchandani

@SandhyaaGopchandani you need to add an nblink file in this folder https://github.com/SeldonIO/seldon-core/tree/master/doc/source/examples and an entry in notebooks.rst https://github.com/SeldonIO/seldon-core/blob/master/doc/source/examples/notebooks.rst.

This is required for your example to appear in the docs.

@axsaucedo I have updated the code, included the model files as well as notebook file that generated the binaries.
Regarding nblink, Does it have to be a path to Notebook file showing the steps? I have structured the example repository differently. Wonder if that is okay?

[axsaucedo]

@SandhyaaGopchandani thank you for adding the updates. In regards to your question, you will have to addd a new file in this folder:

• https://github.com/SeldonIO/seldon-core/tree/master/doc/source/examples

Once you add a new file there, you will then just add an entry in notebooks.rst which contains the path to that nblink file:

• https://github.com/SeldonIO/seldon-core/blob/master/doc/source/examples/notebooks.rst

One more piece to add. I think I didn't specify what I meant by making sure that the .h5 and pkl files are present, what i meant is that we need to enable people following this example to actually be able to builld it. However we can't just copy the whole binary files in the repo as they would be quite heavy, so what we normally do is providing the code required to train the model, You can see how we do it in this example: https://github.com/SeldonIO/seldon-core/blob/master/examples/models/deep_mnist/deep_mnist.ipynb

[gosandhya]

Hello @axsaucedo, thanks for the comment!
I have updated the git repo(s) to add the training code to generate the model files. I have also added nblink files and references in the notebooks.rst file.
Seems it should be good now! Please let me know if there is anything needed to be updated.

Sandhya

[axsaucedo]

/ok-to-test

[axsaucedo]

/lgtm

[seldondev]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [axsaucedo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[axsaucedo]

Thank you for your contribution @SandhyaaGopchandani

[seldondev]

@SandhyaaGopchandani: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
lint	3fec8c8	link	/test lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.