tags backward compatibility in executor #1481

RafalSkolasinski · 2020-02-25T14:18:00Z

Closes #1474.

To avoid missing some important details in between @seldondev messages I will post general updates to the issue itself.

seldondev · 2020-02-25T14:19:14Z

Tue Feb 25 14:19:13 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1481/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1481 --build=1

seldondev · 2020-02-25T14:19:23Z

Tue Feb 25 14:19:22 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1481/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1481 --build=2

seldondev · 2020-02-26T16:40:35Z

Wed Feb 26 16:40:34 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1481/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1481 --build=4

seldondev · 2020-02-26T16:40:49Z

Wed Feb 26 16:40:48 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1481/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1481 --build=3

seldondev · 2020-02-26T17:41:18Z

Wed Feb 26 17:41:17 UTC 2020
The logs for [lint] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1481/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1481 --build=8

seldondev · 2020-02-26T17:41:18Z

Wed Feb 26 17:41:17 UTC 2020
The logs for [pr-build] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1481/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1481 --build=7

seldondev · 2020-02-26T17:45:15Z

Wed Feb 26 17:45:14 UTC 2020
The logs for [lint] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1481/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1481 --build=10

seldondev · 2020-02-26T17:45:17Z

Wed Feb 26 17:45:15 UTC 2020
The logs for [pr-build] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1481/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1481 --build=9

seldondev · 2020-02-26T17:52:34Z

Wed Feb 26 17:52:33 UTC 2020
The logs for [lint] [12] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1481/12.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1481 --build=12

seldondev · 2020-02-26T17:53:48Z

Wed Feb 26 17:53:47 UTC 2020
The logs for [pr-build] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1481/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1481 --build=11

RafalSkolasinski · 2020-02-27T10:35:40Z

/test integration

seldondev · 2020-02-27T10:36:57Z

Thu Feb 27 10:36:56 UTC 2020
The logs for [integration] [13] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1481/13.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1481 --build=13

RafalSkolasinski · 2020-02-27T11:57:06Z

/retest

seldondev · 2020-02-27T11:58:14Z

Thu Feb 27 11:58:13 UTC 2020
The logs for [integration] [14] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1481/14.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1481 --build=14

seldondev · 2020-03-03T10:20:08Z

Tue Mar 3 10:20:07 UTC 2020
The logs for [pr-build] [48] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1481/48.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1481 --build=48

RafalSkolasinski · 2020-03-03T10:22:47Z

The midnight integration tests failed on

test_rolling_update_deployment[graph1.json-graph4.json-ambas]

I have now rebased on master and squash commits. We will see how this run will finish.

RafalSkolasinski · 2020-03-03T10:37:13Z

Now locally it failed for me on

test_rolling_update_deployment[graph1.json-graph3.json-istio]
test_rolling_update_deployment[graph1.json-graph5.json-istio]

RafalSkolasinski · 2020-03-03T12:51:06Z

This is the rolling_updates tests failing all the time. My new tests seems to be passing.

RafalSkolasinski · 2020-03-03T12:59:11Z

/retest

seldondev · 2020-03-03T13:00:40Z

Tue Mar 3 13:00:39 UTC 2020
The logs for [integration] [51] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1481/51.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1481 --build=51

RafalSkolasinski · 2020-03-03T16:37:16Z

/retest

seldondev · 2020-03-03T16:38:29Z

Tue Mar 3 16:38:28 UTC 2020
The logs for [integration] [52] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1481/52.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1481 --build=52

axsaucedo · 2020-03-03T19:15:50Z

/retest

seldondev · 2020-03-03T19:16:59Z

Tue Mar 3 19:16:58 UTC 2020
The logs for [integration] [53] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1481/53.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1481 --build=53

axsaucedo

Really solid tests, and nice one changing prints to logging.info. I added a brief set of followup comments on the way meta is dealt with, but other than that looks good.

Test do seem to be failing due to flakeyness as in the latest one only 1 failed. @RafalSkolasinski can you confirm the tests pass locally? If so happy to merge!

python/seldon_core/utils.py

RafalSkolasinski · 2020-03-04T11:24:22Z

/test integration

RafalSkolasinski · 2020-03-04T11:24:40Z

I have increased flakiness, we will see if it will pass now.

seldondev · 2020-03-04T11:24:58Z

Wed Mar 4 11:24:57 UTC 2020
The logs for [lint] [55] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1481/55.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1481 --build=55

seldondev · 2020-03-04T11:25:36Z

Wed Mar 4 11:25:35 UTC 2020
The logs for [integration] [56] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1481/56.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1481 --build=56

seldondev · 2020-03-04T11:26:24Z

Wed Mar 4 11:26:23 UTC 2020
The logs for [pr-build] [54] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1481/54.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1481 --build=54

axsaucedo

Looks solid!
/approve
/lgtm

seldondev · 2020-03-04T11:48:57Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [axsaucedo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

seldondev · 2020-03-04T12:56:57Z

@RafalSkolasinski: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
integration	`4b3fa19`	link	`/test integration`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

RafalSkolasinski · 2020-03-04T14:41:39Z

All tests pass locally now. The latest problem was with new notebook tests.
There were 4 of them that kept failing due to missing python dependencies, see #1504.

The only one that I didn't manage to run is

test_notebooks.py::TestNotebooks::test_explainer_examples

which is quite odd because I verified that corresponding notebook run without any problems.

@cliveseldon

seldondev added do-not-merge/work-in-progress size/S labels Feb 25, 2020

RafalSkolasinski force-pushed the issue/1474 branch from 81c7b82 to 74e4b4e Compare February 26, 2020 16:38

seldondev added size/M and removed size/S labels Feb 26, 2020

RafalSkolasinski force-pushed the issue/1474 branch from 74e4b4e to 772a62f Compare February 26, 2020 17:39

seldondev added size/L and removed size/M labels Feb 26, 2020

RafalSkolasinski force-pushed the issue/1474 branch from 231d85b to 41dffda Compare February 26, 2020 17:43

seldondev added size/M and removed size/L labels Feb 26, 2020

RafalSkolasinski force-pushed the issue/1474 branch from 41dffda to 3b4b975 Compare February 26, 2020 17:48

seldondev added size/L and removed size/M labels Feb 26, 2020

RafalSkolasinski mentioned this pull request Feb 27, 2020

executor: tags do not propagate through inference graph #1474

Closed

RafalSkolasinski mentioned this pull request Feb 27, 2020

Jenkins X integration broken #1484

Closed

RafalSkolasinski changed the title ~~WIP: tags backward compatibility in executor~~ tags backward compatibility in executor Mar 3, 2020

seldondev removed the do-not-merge/work-in-progress label Mar 3, 2020

RafalSkolasinski requested a review from axsaucedo March 3, 2020 10:37

axsaucedo suggested changes Mar 3, 2020

View reviewed changes

python/seldon_core/utils.py Show resolved Hide resolved

python/seldon_core/utils.py Outdated Show resolved Hide resolved

apply style fix and increase flakiness

4b3fa19

axsaucedo approved these changes Mar 4, 2020

View reviewed changes

seldondev added lgtm approved labels Mar 4, 2020

axsaucedo approved these changes Mar 4, 2020

View reviewed changes

RafalSkolasinski mentioned this pull request Mar 4, 2020

Flakiness on integration tests #1402

Closed

axsaucedo merged commit 5eb177c into SeldonIO:master Mar 4, 2020

RafalSkolasinski deleted the issue/1474 branch March 17, 2020 10:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tags backward compatibility in executor #1481

tags backward compatibility in executor #1481

RafalSkolasinski commented Feb 25, 2020 •

edited

seldondev commented Feb 25, 2020

seldondev commented Feb 25, 2020

seldondev commented Feb 26, 2020

seldondev commented Feb 26, 2020

seldondev commented Feb 26, 2020

seldondev commented Feb 26, 2020

seldondev commented Feb 26, 2020

seldondev commented Feb 26, 2020

seldondev commented Feb 26, 2020

seldondev commented Feb 26, 2020

RafalSkolasinski commented Feb 27, 2020

seldondev commented Feb 27, 2020

RafalSkolasinski commented Feb 27, 2020

seldondev commented Feb 27, 2020

seldondev commented Mar 3, 2020

RafalSkolasinski commented Mar 3, 2020

RafalSkolasinski commented Mar 3, 2020

RafalSkolasinski commented Mar 3, 2020

RafalSkolasinski commented Mar 3, 2020

seldondev commented Mar 3, 2020

RafalSkolasinski commented Mar 3, 2020

seldondev commented Mar 3, 2020

axsaucedo commented Mar 3, 2020

seldondev commented Mar 3, 2020

axsaucedo left a comment

RafalSkolasinski commented Mar 4, 2020

RafalSkolasinski commented Mar 4, 2020

seldondev commented Mar 4, 2020

seldondev commented Mar 4, 2020

seldondev commented Mar 4, 2020

axsaucedo left a comment

seldondev commented Mar 4, 2020

seldondev commented Mar 4, 2020

RafalSkolasinski commented Mar 4, 2020 •

edited

tags backward compatibility in executor #1481

tags backward compatibility in executor #1481

Conversation

RafalSkolasinski commented Feb 25, 2020 • edited

seldondev commented Feb 25, 2020

seldondev commented Feb 25, 2020

seldondev commented Feb 26, 2020

seldondev commented Feb 26, 2020

seldondev commented Feb 26, 2020

seldondev commented Feb 26, 2020

seldondev commented Feb 26, 2020

seldondev commented Feb 26, 2020

seldondev commented Feb 26, 2020

seldondev commented Feb 26, 2020

RafalSkolasinski commented Feb 27, 2020

seldondev commented Feb 27, 2020

RafalSkolasinski commented Feb 27, 2020

seldondev commented Feb 27, 2020

seldondev commented Mar 3, 2020

RafalSkolasinski commented Mar 3, 2020

RafalSkolasinski commented Mar 3, 2020

RafalSkolasinski commented Mar 3, 2020

RafalSkolasinski commented Mar 3, 2020

seldondev commented Mar 3, 2020

RafalSkolasinski commented Mar 3, 2020

seldondev commented Mar 3, 2020

axsaucedo commented Mar 3, 2020

seldondev commented Mar 3, 2020

axsaucedo left a comment

Choose a reason for hiding this comment

RafalSkolasinski commented Mar 4, 2020

RafalSkolasinski commented Mar 4, 2020

seldondev commented Mar 4, 2020

seldondev commented Mar 4, 2020

seldondev commented Mar 4, 2020

axsaucedo left a comment

Choose a reason for hiding this comment

seldondev commented Mar 4, 2020

seldondev commented Mar 4, 2020

RafalSkolasinski commented Mar 4, 2020 • edited

RafalSkolasinski commented Feb 25, 2020 •

edited

RafalSkolasinski commented Mar 4, 2020 •

edited