Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose rest feedback endpoint in executor #1833

Conversation

RafalSkolasinski
Copy link
Member

closes #1825

@seldondev
Copy link
Collaborator

Fri May 15 15:20:46 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1833/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1833 --build=2

@seldondev
Copy link
Collaborator

Fri May 15 15:20:56 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1833/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1833 --build=1

@RafalSkolasinski
Copy link
Member Author

/retest

@seldondev
Copy link
Collaborator

Fri May 15 15:33:50 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1833/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1833 --build=3

@RafalSkolasinski
Copy link
Member Author

/test integration

@seldondev
Copy link
Collaborator

Fri May 15 15:48:56 UTC 2020
The logs for [integration] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1833/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1833 --build=4

r.Router.NewRoute().Path("/api/v1.0/status/{" + ModelHttpPathVariable + "}").Methods("GET").HandlerFunc(r.wrapMetrics(metric.StatusHttpServiceName, r.status))
r.Router.NewRoute().Path("/api/v1.0/metadata/{" + ModelHttpPathVariable + "}").Methods("GET").HandlerFunc(r.wrapMetrics(metric.StatusHttpServiceName, r.metadata))
r.Router.NewRoute().Path("/api/v1.0/metadata/{" + ModelHttpPathVariable + "}").Methods("GET").HandlerFunc(r.wrapMetrics(metric.MetadataHttpServiceName, r.metadata))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! So was going to status?

@ukclivecox
Copy link
Contributor

/approve

@seldondev seldondev merged commit 6760434 into SeldonIO:master May 18, 2020
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

failed to trigger Pull Request pipeline

  • failed to create agent
  • failed to calculate in repo config
  • failed to load trigger config for repository SeldonIO/seldon-core for ref a00a124
  • failed to find any lighthouse configuration files in repo SeldonIO/seldon-core at sha a00a124
  • failed to process repo SeldonIO/seldon-core refref a00a124
  • failed to list files in directory /var/tmp/gitrepo660600678/.lighthouse
  • open /var/tmp/gitrepo660600678/.lighthouse
  • no such file or directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feedback method is not handled in the engine's REST API
3 participants