Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ambassador.md #2245

Merged
merged 1 commit into from
Aug 10, 2020
Merged

Update ambassador.md #2245

merged 1 commit into from
Aug 10, 2020

Conversation

omerfsen
Copy link
Contributor

@omerfsen omerfsen commented Aug 5, 2020

With this sample yaml we are getting:

  "status": {
    "code": -1,
    "info": "Empty json parameter in data",
    "reason": "MICROSERVICE_BAD_DATA",
    "status": 1
  }
}

error which is related with https://docs.seldon.io/projects/seldon-core/en/latest/reference/upgrading.html#wrapper-compatibility-table and also issue is fixed with new versions #1912 so better use 1.2.1 and 1.2.2 for this on this example.

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

With this sample yaml we are getting:

```{
  "status": {
    "code": -1,
    "info": "Empty json parameter in data",
    "reason": "MICROSERVICE_BAD_DATA",
    "status": 1
  }
}
```
error which is related with https://docs.seldon.io/projects/seldon-core/en/latest/reference/upgrading.html#wrapper-compatibility-table and also issue is fixed with new versions #1912 so better use 1.2.1 and 1.2.2 for this on this example.
@seldondev
Copy link
Collaborator

Hi @omerfsen. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign sachinvarghese
You can assign the PR to them by writing /assign @sachinvarghese in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@axsaucedo
Copy link
Contributor

/approve

@axsaucedo axsaucedo merged commit c94b7b6 into SeldonIO:master Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants