Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try allowing unknown istio fields #2266

Merged
merged 1 commit into from
Aug 12, 2020

Conversation

ryandawsonuk
Copy link
Contributor

Trying this based on @axsaucedo discovering https://github.com/knative-sandbox/net-istio/pull/114/files

Hopefully could resolve #1551, which has resurfaced in 1.2.2

@ryandawsonuk
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Wed Aug 12 17:56:34 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2266/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2266 --build=1

@seldondev
Copy link
Collaborator

Wed Aug 12 17:56:58 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2266/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2266 --build=2

@seldondev
Copy link
Collaborator

Wed Aug 12 17:57:49 UTC 2020
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2266/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2266 --build=3

@axsaucedo
Copy link
Contributor

Nice one @ryandawsonuk! Looks good to go

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit e7f4c76 into SeldonIO:master Aug 12, 2020
@ryandawsonuk
Copy link
Contributor Author

Have checked this against istio 1.1 and was able to see virtualservices created and call services through istio gateway correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade process from v1.0.2
3 participants