-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add gRPC reflection support for seldon-core-executor and python wrapper #2395
Conversation
Hi @CatTail. Thanks for your PR. I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. |
/assign @jklaise |
Hi @jklaise can you help to take a look at this PR? |
/ok-to-test |
/test integration |
/approve |
Wed Sep 9 06:32:54 UTC 2020 impatient try |
Wed Sep 9 06:33:04 UTC 2020 impatient try |
Wed Sep 9 06:33:41 UTC 2020 impatient try |
@CatTail you need to run |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cliveseldon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Wed Sep 9 07:13:53 UTC 2020 impatient try |
Wed Sep 9 07:13:53 UTC 2020 impatient try |
/test lint |
Wed Sep 9 07:29:18 UTC 2020 impatient try |
Can you rebase from master as it seems to be failing on new licenses? |
Wed Sep 9 08:38:30 UTC 2020 impatient try |
Wed Sep 9 08:38:36 UTC 2020 impatient try |
Wed Sep 9 09:19:14 UTC 2020 impatient try |
Wed Sep 9 09:19:20 UTC 2020 impatient try |
@cliveseldon looks like the lint failed due to license change, should I commit these license changes in this PR? |
@CatTail just following up with the above, let me know, otherwise happy to rebase and do the changes |
@axsaucedo sorry for the late reply, I just update this PR, can you help to review it again. |
Wed Nov 25 13:31:36 UTC 2020 impatient try |
Wed Nov 25 13:31:46 UTC 2020 impatient try |
@CatTail: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here. |
Wed Nov 25 14:28:59 UTC 2020 impatient try |
Wed Nov 25 14:29:11 UTC 2020 impatient try |
Thank you @CatTail ! |
What this PR does / why we need it:
Enable gRPC reflection for Go seldon-core-executor and the python wrapper, with gRPC reflection we can inspect server APIs easily, for example with grpcurl,
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: