Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gRPC reflection support for seldon-core-executor and python wrapper #2395

Merged
merged 4 commits into from
Nov 25, 2020
Merged

add gRPC reflection support for seldon-core-executor and python wrapper #2395

merged 4 commits into from
Nov 25, 2020

Conversation

CatTail
Copy link
Contributor

@CatTail CatTail commented Sep 7, 2020

What this PR does / why we need it:

Enable gRPC reflection for Go seldon-core-executor and the python wrapper, with gRPC reflection we can inspect server APIs easily, for example with grpcurl,

$ grpcurl -plaintext localhost:8000 list
grpc.reflection.v1alpha.ServerReflection
seldon.protos.Seldon

$ grpcurl -plaintext localhost:8000 list seldon.protos.Seldon
seldon.protos.Seldon.GraphMetadata
seldon.protos.Seldon.ModelMetadata
seldon.protos.Seldon.Predict
seldon.protos.Seldon.SendFeedback

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

add gRPC reflection support for seldon-core-executor and python wrapper

@seldondev
Copy link
Collaborator

Hi @CatTail. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@CatTail CatTail changed the title enable gRPC reflection for seldon-core-executor and python wrapper add gRPC reflection support for seldon-core-executor and python wrapper Sep 7, 2020
@CatTail
Copy link
Contributor Author

CatTail commented Sep 7, 2020

/assign @jklaise

@CatTail
Copy link
Contributor Author

CatTail commented Sep 9, 2020

Hi @jklaise can you help to take a look at this PR?

@ukclivecox ukclivecox assigned ukclivecox and unassigned jklaise Sep 9, 2020
@ukclivecox
Copy link
Contributor

/ok-to-test

@ukclivecox
Copy link
Contributor

/test integration

@ukclivecox
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

Wed Sep 9 06:32:54 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2395/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2395 --build=1

@seldondev
Copy link
Collaborator

Wed Sep 9 06:33:04 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2395/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2395 --build=2

@seldondev
Copy link
Collaborator

Wed Sep 9 06:33:41 UTC 2020
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2395/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2395 --build=3

@ukclivecox
Copy link
Contributor

@CatTail you need to run make fmt in the python folder

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Wed Sep 9 07:13:53 UTC 2020
The logs for [lint] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2395/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2395 --build=5

@seldondev
Copy link
Collaborator

Wed Sep 9 07:13:53 UTC 2020
The logs for [pr-build] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2395/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2395 --build=4

@ukclivecox
Copy link
Contributor

/test lint

@seldondev
Copy link
Collaborator

Wed Sep 9 07:29:18 UTC 2020
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2395/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2395 --build=6

@ukclivecox
Copy link
Contributor

Can you rebase from master as it seems to be failing on new licenses?

@seldondev
Copy link
Collaborator

Wed Sep 9 08:38:30 UTC 2020
The logs for [pr-build] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2395/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2395 --build=7

@seldondev
Copy link
Collaborator

Wed Sep 9 08:38:36 UTC 2020
The logs for [lint] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2395/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2395 --build=8

@seldondev
Copy link
Collaborator

Wed Sep 9 09:19:14 UTC 2020
The logs for [lint] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2395/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2395 --build=10

@seldondev
Copy link
Collaborator

Wed Sep 9 09:19:20 UTC 2020
The logs for [pr-build] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2395/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2395 --build=9

@CatTail
Copy link
Contributor Author

CatTail commented Sep 10, 2020

@cliveseldon looks like the lint failed due to license change, should I commit these license changes in this PR?

@axsaucedo axsaucedo requested review from adriangonz and ukclivecox and removed request for adriangonz November 12, 2020 10:07
@axsaucedo
Copy link
Contributor

@CatTail apologies for the delayed response, seems this may have slipped - this would be quite a useful addition to merge this. Would you be able to rebase from master and resolve conflicts? If you wouldn't be able let me know and we can help adding some of the changes. Thanks @CatTail !

@axsaucedo axsaucedo self-requested a review November 17, 2020 08:01
@axsaucedo
Copy link
Contributor

@CatTail just following up with the above, let me know, otherwise happy to rebase and do the changes

@CatTail
Copy link
Contributor Author

CatTail commented Nov 25, 2020

@axsaucedo sorry for the late reply, I just update this PR, can you help to review it again.

@seldondev
Copy link
Collaborator

Wed Nov 25 13:31:36 UTC 2020
The logs for [pr-build] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2395/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2395 --build=11

@seldondev
Copy link
Collaborator

Wed Nov 25 13:31:46 UTC 2020
The logs for [lint] [12] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2395/12.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2395 --build=12

@seldondev
Copy link
Collaborator

seldondev commented Nov 25, 2020

@CatTail: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integration 788dea3 link /test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@seldondev seldondev added size/XL and removed size/S labels Nov 25, 2020
@seldondev
Copy link
Collaborator

Wed Nov 25 14:28:59 UTC 2020
The logs for [pr-build] [13] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2395/13.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2395 --build=13

@seldondev
Copy link
Collaborator

Wed Nov 25 14:29:11 UTC 2020
The logs for [lint] [14] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2395/14.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2395 --build=14

@seldondev seldondev merged commit 7857229 into SeldonIO:master Nov 25, 2020
@CatTail CatTail deleted the feat/grpc-reflection branch November 25, 2020 14:40
@axsaucedo
Copy link
Contributor

Thank you @CatTail !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants