Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource usage at sdep level #2484

Merged
merged 3 commits into from
Sep 30, 2020

Conversation

ryandawsonuk
Copy link
Contributor

@ryandawsonuk ryandawsonuk commented Sep 24, 2020

fixes #2483
Allows us to apply recording rules based loosely on https://deploy.live/blog/today-i-learned-prometheus-recording-rules/
Not including the recording rules in this PR as can be loaded into configmap and referenced in extraConfigmapMounts. But they're also in the PR's commit history.

@seldondev
Copy link
Collaborator

Thu Sep 24 15:41:33 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2484/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2484 --build=2

@seldondev
Copy link
Collaborator

Thu Sep 24 15:41:37 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2484/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2484 --build=1

@seldondev
Copy link
Collaborator

Fri Sep 25 16:02:22 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2484/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2484 --build=4

@seldondev
Copy link
Collaborator

Fri Sep 25 16:02:25 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2484/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2484 --build=3

@seldondev seldondev added size/M and removed size/L labels Sep 28, 2020
@seldondev
Copy link
Collaborator

Mon Sep 28 14:40:40 UTC 2020
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2484/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2484 --build=5

@seldondev
Copy link
Collaborator

Mon Sep 28 14:41:02 UTC 2020
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2484/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2484 --build=6

@ryandawsonuk
Copy link
Contributor Author

/lgtm
/approve

@seldondev
Copy link
Collaborator

@ryandawsonuk: you cannot LGTM your own PR.

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ryandawsonuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Wed Sep 30 16:28:56 UTC 2020
The logs for [pr-build] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2484/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2484 --build=7

@seldondev
Copy link
Collaborator

Wed Sep 30 16:29:06 UTC 2020
The logs for [lint] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2484/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2484 --build=8

@seldondev seldondev merged commit 41a4620 into SeldonIO:master Sep 30, 2020
@ukclivecox ukclivecox added this to In progress in 1.4 via automation Oct 1, 2020
@ukclivecox ukclivecox added this to the 1.4 milestone Oct 1, 2020
@ukclivecox ukclivecox moved this from In progress to Done in 1.4 Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
1.4
  
Done
Development

Successfully merging this pull request may close these issues.

prometheus metrics for usage by seldondeployment
3 participants