Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix integration test caused by protobuf binary #2530

Merged
merged 2 commits into from
Oct 8, 2020

Conversation

anggao
Copy link
Contributor

@anggao anggao commented Oct 7, 2020

What this PR does / why we need it:
protobuf binary wheels caused namespace collisions, this PR is to avoid install it

Which issue(s) this PR fixes:

Fixes #2529

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@seldondev
Copy link
Collaborator

Hi @anggao. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@anggao
Copy link
Contributor Author

anggao commented Oct 7, 2020

These extra file changes caused by make build_apis

@anggao
Copy link
Contributor Author

anggao commented Oct 7, 2020

/test integration

@seldondev
Copy link
Collaborator

@anggao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@axsaucedo
Copy link
Contributor

Awesome @anggao !
/ok-to-test
/test integration

@seldondev
Copy link
Collaborator

Thu Oct 8 06:09:54 UTC 2020
The logs for [integration] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2530/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2530 --build=2

@seldondev
Copy link
Collaborator

Thu Oct 8 06:09:59 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2530/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2530 --build=1

@seldondev
Copy link
Collaborator

Thu Oct 8 06:10:06 UTC 2020
The logs for [lint] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2530/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2530 --build=3

@axsaucedo
Copy link
Contributor

NIce @anggao ! It seems all passes! lint is failing, could you rebase iwth master and run the licenses script?

Other than that it's good to go!
/approve

@axsaucedo
Copy link
Contributor

/rebase

@axsaucedo
Copy link
Contributor

@anggao seems it can't automatically rebase, so as soon as you rebase it manually it should be good to merge

@anggao
Copy link
Contributor Author

anggao commented Oct 8, 2020

@axsaucedo great! I will do

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Thu Oct 8 09:35:37 UTC 2020
The logs for [pr-build] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2530/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2530 --build=4

@seldondev
Copy link
Collaborator

Thu Oct 8 09:35:41 UTC 2020
The logs for [lint] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2530/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2530 --build=5

@anggao
Copy link
Contributor Author

anggao commented Oct 8, 2020

/test integration

@seldondev
Copy link
Collaborator

Thu Oct 8 09:39:34 UTC 2020
The logs for [integration] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2530/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2530 --build=6

@anggao
Copy link
Contributor Author

anggao commented Oct 8, 2020

Looks like I need to fix the licence file under python folder

@seldondev seldondev added size/XXL and removed size/M labels Oct 8, 2020
@anggao
Copy link
Contributor Author

anggao commented Oct 8, 2020

/test integration

@seldondev
Copy link
Collaborator

Thu Oct 8 10:02:30 UTC 2020
The logs for [lint] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2530/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2530 --build=8

@seldondev
Copy link
Collaborator

Thu Oct 8 10:02:32 UTC 2020
The logs for [integration] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2530/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2530 --build=9

@seldondev
Copy link
Collaborator

Thu Oct 8 10:02:33 UTC 2020
The logs for [pr-build] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2530/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2530 --build=7

@anggao
Copy link
Contributor Author

anggao commented Oct 8, 2020

@axsaucedo do you know why the second integration run failed ?

@anggao
Copy link
Contributor Author

anggao commented Oct 8, 2020

Looks like failed here: TestPrepack.test_sklearn_v2
but I didn't change anything related to that :(

@anggao
Copy link
Contributor Author

anggao commented Oct 8, 2020

/test integration

@seldondev
Copy link
Collaborator

Thu Oct 8 11:22:45 UTC 2020
The logs for [integration] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2530/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2530 --build=10

@seldondev seldondev merged commit 2305d73 into SeldonIO:master Oct 8, 2020
@axsaucedo
Copy link
Contributor

@anggao it seems that test was just flaky, thank you for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration test failed due to alibi_explainer container
3 participants