-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix integration test caused by protobuf binary #2530
Conversation
Hi @anggao. Thanks for your PR. I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. |
These extra file changes caused by |
/test integration |
@anggao: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. |
Awesome @anggao ! |
Thu Oct 8 06:09:54 UTC 2020 impatient try |
Thu Oct 8 06:09:59 UTC 2020 impatient try |
Thu Oct 8 06:10:06 UTC 2020 impatient try |
NIce @anggao ! It seems all passes! lint is failing, could you rebase iwth master and run the licenses script? Other than that it's good to go! |
/rebase |
@anggao seems it can't automatically rebase, so as soon as you rebase it manually it should be good to merge |
@axsaucedo great! I will do |
ae7308c
to
03a530c
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thu Oct 8 09:35:37 UTC 2020 impatient try |
Thu Oct 8 09:35:41 UTC 2020 impatient try |
/test integration |
Thu Oct 8 09:39:34 UTC 2020 impatient try |
Looks like I need to fix the licence file under python folder |
/test integration |
Thu Oct 8 10:02:30 UTC 2020 impatient try |
Thu Oct 8 10:02:32 UTC 2020 impatient try |
Thu Oct 8 10:02:33 UTC 2020 impatient try |
@axsaucedo do you know why the second integration run failed ? |
Looks like failed here: |
/test integration |
Thu Oct 8 11:22:45 UTC 2020 impatient try |
@anggao it seems that test was just flaky, thank you for the fix! |
What this PR does / why we need it:
protobuf binary wheels caused namespace collisions, this PR is to avoid install it
Which issue(s) this PR fixes:
Fixes #2529
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE