Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed AD Server Dependencies and Added notebook integration test #2536

Merged
merged 6 commits into from
Oct 9, 2020

Conversation

axsaucedo
Copy link
Contributor

@axsaucedo axsaucedo commented Oct 8, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #2533

Fixes #2535

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@seldondev
Copy link
Collaborator

Thu Oct 8 14:55:13 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2536/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2536 --build=2

@seldondev
Copy link
Collaborator

Thu Oct 8 14:55:15 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2536/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2536 --build=1

@seldondev seldondev added size/XXL and removed size/XS labels Oct 8, 2020
@axsaucedo axsaucedo changed the title Updated setup.pyto include dependency guards Fixed AD Server Dependencies and Added notebook integration test Oct 8, 2020
@axsaucedo
Copy link
Contributor Author

/test notebooks

@seldondev
Copy link
Collaborator

Thu Oct 8 15:59:59 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2536/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2536 --build=3

@seldondev
Copy link
Collaborator

Thu Oct 8 16:00:23 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2536/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2536 --build=4

@seldondev
Copy link
Collaborator

Thu Oct 8 16:03:09 UTC 2020
The logs for [notebooks] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2536/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2536 --build=5

@axsaucedo
Copy link
Contributor Author

It seems failed tests are unrelated, namely the test_custom_metrics - the errors seem similar to the proto error in the explainer notebook tests tho. Re-running to confirm whether it's flakiness.
/test notebooks

@seldondev
Copy link
Collaborator

Thu Oct 8 18:24:13 UTC 2020
The logs for [notebooks] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2536/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2536 --build=6

@axsaucedo
Copy link
Contributor Author

/test notebooks

@seldondev
Copy link
Collaborator

Thu Oct 8 19:49:37 UTC 2020
The logs for [notebooks] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2536/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2536 --build=7

@axsaucedo
Copy link
Contributor Author

/test notebooks

@seldondev
Copy link
Collaborator

Fri Oct 9 07:17:12 UTC 2020
The logs for [lint] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2536/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2536 --build=9

@seldondev
Copy link
Collaborator

Fri Oct 9 07:17:24 UTC 2020
The logs for [notebooks] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2536/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2536 --build=10

@seldondev
Copy link
Collaborator

Fri Oct 9 07:17:46 UTC 2020
The logs for [pr-build] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2536/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2536 --build=8

@axsaucedo
Copy link
Contributor Author

/test this

@seldondev
Copy link
Collaborator

Fri Oct 9 07:38:33 UTC 2020
The logs for [pr-build] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2536/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2536 --build=11

@axsaucedo
Copy link
Contributor Author

I just ran the custom_metrics test locally and works as expected, so seems it's due to flakiness

@axsaucedo
Copy link
Contributor Author

/test notebooks

@seldondev
Copy link
Collaborator

Fri Oct 9 12:19:32 UTC 2020
The logs for [notebooks] [12] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2536/12.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2536 --build=12

@seldondev
Copy link
Collaborator

@axsaucedo: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
notebooks bd2ec59 link /test notebooks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@axsaucedo
Copy link
Contributor Author

/approve

@axsaucedo axsaucedo merged commit 4e51998 into SeldonIO:master Oct 9, 2020
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@anggao
Copy link
Contributor

anggao commented Oct 9, 2020

@axsaucedo I think I have the similar issue with my PR :(

#2506

@anggao
Copy link
Contributor

anggao commented Oct 9, 2020

Ah just saw your comments :) thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add integration test for outlier detection server ADServer Crashes due to updated dependencies
3 participants