-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dead links in docs and add linter #2538
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Thu Oct 8 16:47:08 UTC 2020 impatient try |
Thu Oct 8 16:47:23 UTC 2020 impatient try |
Thu Oct 8 16:59:13 UTC 2020 impatient try |
Thu Oct 8 16:59:17 UTC 2020 impatient try |
/test docs |
Thu Oct 8 17:06:08 UTC 2020 impatient try |
Thu Oct 8 17:06:08 UTC 2020 impatient try |
Thu Oct 8 17:09:13 UTC 2020 impatient try |
/cc @cliveseldon @axsaucedo @RafalSkolasinski |
This is great! Looks good! Seems there may need to be a small change on the image as build looks like pandoc is missing, but other than that looks great! |
@axsaucedo good spot! I've now pushed a new version of the image. |
Fri Oct 9 11:17:10 UTC 2020 impatient try |
Fri Oct 9 11:17:22 UTC 2020 impatient try |
/test docs |
Fri Oct 9 11:20:16 UTC 2020 impatient try |
/test docs |
Fri Oct 9 13:02:35 UTC 2020 impatient try |
Fri Oct 9 13:02:50 UTC 2020 impatient try |
Fri Oct 9 13:03:52 UTC 2020 impatient try |
/approve |
@adriangonz seems there are some merge conflicts, but other than that should be good to go |
40725b9
to
f8d961a
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fri Oct 9 16:27:38 UTC 2020 impatient try |
Fri Oct 9 16:27:53 UTC 2020 impatient try |
What this PR does / why we need it:
Fix most warnings thrown by Sphinx, some dead links, and upgrade the versions of the docs' dependencies. This PR also adds a
/docs
command which runs some linters on the docs and also crawls all external links to verify they are working.Which issue(s) this PR fixes:
Fixes #1760
Special notes for your reviewer:
/docs
command./doc
folder for absolute links to the Seldon Core docs. This is to work around a limitation onnbsphinx-link
./doc
folder to use instead theextra-media
key on thenblink
file.Does this PR introduce a user-facing change?: