Operator sdk v1 #2543
Operator sdk v1 #2543
Conversation
|
Sun Oct 11 17:35:14 UTC 2020 impatient try |
|
Sun Oct 11 17:35:19 UTC 2020 impatient try |
| manifests_v1: controller-gen | ||
| $(CONTROLLER_GEN) $(CRD_OPTIONS) rbac:roleName=manager-role webhook paths="./..." output:crd:artifacts:config=config/crd_v1/bases crd:crdVersions=v1 | ||
| $(CONTROLLER_GEN) rbac:roleName=manager-role webhook paths="./..." output:crd:artifacts:config=config/crd_v1/bases crd:crdVersions=v1 | ||
| #$(CONTROLLER_GEN) rbac:roleName=manager-role webhook paths="./apis/machinelearning.seldon.io/v1" output:crd:artifacts:config=config/crd_v1/bases crd:crdVersions=v1 |
There was a problem hiding this comment.
They are not the same. This is the addition to possibly at later to only create v1 SeldonDeployment CRD
|
Mon Oct 12 10:03:39 UTC 2020 impatient try |
|
Mon Oct 12 10:03:50 UTC 2020 impatient try |
| sourceNamespace: marketplace | ||
| startingCSV: seldon-operator.v1.1.0 | ||
| startingCSV: seldon-operator.v1.2.2 |
There was a problem hiding this comment.
Is this expected to be 1.2.2 instead of 1.3?
There was a problem hiding this comment.
1.2.2 is last official release. Actually always good we leave this at 1.2.2 as we can check auto upgrades
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Updates the openshift release process to use to latest operator-sdk and conform to the new bundle requirements: https://redhat-connect.gitbook.io/certified-operator-guide/appendix/bundle-maintenance-after-migration
operator/seldon-operatoroperator/Makefileto create bundle and package manifests and build images for openshift bundle images for testing via quay or push for certified operatorThe new setup is following kubebuilder so this work allows us to align more closely.
Also includes updates to v1beta1 CRD so it actually can be run in k8s 1.18
Which issue(s) this PR fixes:
Fixes #2532
Special notes for your reviewer:
Please see the added readme files for details and future challenges w.r.t use of v1 CRD.
Does this PR introduce a user-facing change?: