Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MLServer image to 0.1.1 #2558

Merged
merged 4 commits into from Nov 3, 2020
Merged

Conversation

adriangonz
Copy link
Contributor

What this PR does / why we need it:
Bump seldonio/mlserver to 0.1.1, which fixes a couple issues around gRPC. This allows to use MLServer with the same proto definitions as Triton.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@adriangonz
Copy link
Contributor Author

/test engine

@adriangonz
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Mon Oct 19 16:47:12 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2558/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2558 --build=1

@seldondev
Copy link
Collaborator

Mon Oct 19 16:47:20 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2558/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2558 --build=2

@seldondev
Copy link
Collaborator

Mon Oct 19 16:47:38 UTC 2020
The logs for [engine] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2558/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2558 --build=3

@seldondev
Copy link
Collaborator

Mon Oct 19 16:47:40 UTC 2020
The logs for [integration] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2558/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2558 --build=4

@seldondev
Copy link
Collaborator

Mon Oct 19 18:28:17 UTC 2020
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2558/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2558 --build=6

@seldondev
Copy link
Collaborator

Mon Oct 19 18:28:17 UTC 2020
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2558/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2558 --build=5

@adriangonz
Copy link
Contributor Author

/test engine

@adriangonz
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Mon Oct 19 18:30:54 UTC 2020
The logs for [engine] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2558/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2558 --build=7

@seldondev
Copy link
Collaborator

Mon Oct 19 18:31:42 UTC 2020
The logs for [integration] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2558/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2558 --build=8

@adriangonz
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Tue Oct 20 08:48:23 UTC 2020
The logs for [integration] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2558/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2558 --build=9

@adriangonz
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Tue Oct 20 14:21:05 UTC 2020
The logs for [integration] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2558/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2558 --build=10

@seldondev seldondev added size/M and removed size/S labels Oct 20, 2020
@adriangonz
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Tue Oct 20 15:48:52 UTC 2020
The logs for [pr-build] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2558/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2558 --build=11

@seldondev
Copy link
Collaborator

Tue Oct 20 15:48:52 UTC 2020
The logs for [lint] [12] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2558/12.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2558 --build=12

@seldondev
Copy link
Collaborator

Tue Oct 20 15:49:54 UTC 2020
The logs for [integration] [13] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2558/13.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2558 --build=13

@adriangonz
Copy link
Contributor Author

/cc @cliveseldon @RafalSkolasinski

@axsaucedo
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Thu Oct 29 10:26:52 UTC 2020
The logs for [pr-build] [14] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2558/14.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2558 --build=14

@seldondev
Copy link
Collaborator

Thu Oct 29 10:26:54 UTC 2020
The logs for [lint] [15] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2558/15.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2558 --build=15

@seldondev
Copy link
Collaborator

seldondev commented Oct 29, 2020

@adriangonz: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
engine aad1ab6 link /test engine

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@adriangonz
Copy link
Contributor Author

/test pr-build

@adriangonz
Copy link
Contributor Author

/test this

@seldondev
Copy link
Collaborator

Mon Nov 2 14:18:55 UTC 2020
The logs for [pr-build] [16] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2558/16.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2558 --build=16

@adriangonz
Copy link
Contributor Author

/test this

@seldondev
Copy link
Collaborator

Tue Nov 3 11:23:16 UTC 2020
The logs for [pr-build] [17] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2558/17.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2558 --build=17

@adriangonz adriangonz merged commit 5c2c89a into SeldonIO:master Nov 3, 2020
@adriangonz adriangonz deleted the update-mlserver branch November 3, 2020 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants