Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding prom annotations for feedback metrics server example #2572

Merged
merged 1 commit into from
Oct 22, 2020

Conversation

SachinVarghese
Copy link
Contributor

What this PR does / why we need it:
This PR adds prom annotations for feedback metrics server example so that the metrics are scraped by seldon core analytics Prometheus at regular intervals

Does this PR introduce a user-facing change?:
NONE

@seldondev
Copy link
Collaborator

Thu Oct 22 14:21:02 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2572/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2572 --build=1

@seldondev
Copy link
Collaborator

Thu Oct 22 14:21:18 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2572/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2572 --build=2

@axsaucedo
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

Thu Oct 22 14:44:32 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2572/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2572 --build=4

@seldondev
Copy link
Collaborator

Thu Oct 22 14:44:34 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2572/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2572 --build=3

@axsaucedo axsaucedo merged commit 7abd510 into SeldonIO:master Oct 22, 2020
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants