Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add requestPath metadata on Python Wrapper #2587

Merged
merged 2 commits into from
Nov 16, 2020
Merged

Add requestPath metadata on Python Wrapper #2587

merged 2 commits into from
Nov 16, 2020

Conversation

RafalSkolasinski
Copy link
Contributor

What this PR does / why we need it:

Adds meta.requestPath information on Python Wrapper to ensure backwards compatibility with Engine

Which issue(s) this PR fixes:

Closes #2505

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

requestPath metadata is now added by Python Wrapper to ensure that this functionality added by Engine is present after upgrading to SC version that uses Executor

@RafalSkolasinski RafalSkolasinski marked this pull request as draft October 27, 2020 17:52
@RafalSkolasinski
Copy link
Contributor Author

Just needs to add tests and we should be good

@seldondev
Copy link
Collaborator

Tue Oct 27 17:53:34 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2587/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2587 --build=1

@seldondev
Copy link
Collaborator

Tue Oct 27 17:53:35 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2587/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2587 --build=2

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Tue Oct 27 17:57:57 UTC 2020
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2587/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2587 --build=3

@RafalSkolasinski RafalSkolasinski mentioned this pull request Oct 28, 2020
Closed
@RafalSkolasinski
Copy link
Contributor Author

Just checked that this works nice for both REST and gRPC. Gonna add unit tests and we are good to merge 👍

@seldondev seldondev added size/L and removed size/S labels Nov 2, 2020
@RafalSkolasinski RafalSkolasinski marked this pull request as ready for review November 2, 2020 12:13
@RafalSkolasinski
Copy link
Contributor Author

@axsaucedo added unit tests - I think it's ready to merge
/test integration

@seldondev
Copy link
Collaborator

Mon Nov 2 12:14:43 UTC 2020
The logs for [pr-build] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2587/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2587 --build=4

@seldondev
Copy link
Collaborator

Mon Nov 2 12:15:02 UTC 2020
The logs for [integration] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2587/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2587 --build=6

@seldondev
Copy link
Collaborator

Mon Nov 2 12:15:03 UTC 2020
The logs for [lint] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2587/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2587 --build=5

@RafalSkolasinski
Copy link
Contributor Author

/retest

@seldondev
Copy link
Collaborator

Mon Nov 2 15:31:37 UTC 2020
The logs for [integration] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2587/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2587 --build=7

@seldondev
Copy link
Collaborator

@RafalSkolasinski: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integration 6600321 link /test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@RafalSkolasinski
Copy link
Contributor Author

I see failure in TestPrepack.test_sklearn_v2, is it something flaky @adriangonz ?

axsaucedo
axsaucedo reviewed Nov 9, 2020
View reviewed changes
Copy link
Contributor

@axsaucedo axsaucedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, added a couple of comments, would be good to hear thoughts, but depending on whehter we do it in a separate pr it could be good to go

python/seldon_core/utils.py
@@ -24,6 +24,22 @@
from tensorflow.core.framework.tensor_pb2 import TensorProto


ENV_MODEL_NAME = "PREDICTIVE_UNIT_ID"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not something that you could re-use from the metrics file? I believe you also define this there.

python/seldon_core/utils.py
NONIMPLEMENTED_MSG = "NOT_IMPLEMENTED"

model_name = os.environ.get(ENV_MODEL_NAME, f"{NONIMPLEMENTED_MSG}")
image_name = os.environ.get(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for this, ideally we use the metrics class component for this (or move the logic from metrics to util, but this would require changing the alibi detect server as it now also uses this logic as well)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably better then do it in separate PR as refactoring. The only reason I didn't re-use code from metrics is that this indeed would fit some utils location a bit more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it would be kind of weird to use metrics.model_name for non-metrics related things.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, if you open an issue we should be able to merge 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2621

@axsaucedo
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@axsaucedo axsaucedo merged commit 2a9fc3f into SeldonIO:master Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axsaucedo axsaucedo axsaucedo left review comments

Assignees
No one assigned
Labels
approved size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

requestPath meta missing in new executor
3 participants
@RafalSkolasinski @seldondev @axsaucedo