Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to use KEDA v2.0 GA version in the demo #2615

Merged
merged 1 commit into from Nov 18, 2020

Conversation

anggao
Copy link
Contributor

@anggao anggao commented Nov 5, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #2614

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@seldondev
Copy link
Collaborator

Hi @anggao. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@axsaucedo
Copy link
Contributor

/approve

@axsaucedo
Copy link
Contributor

/ok-to-test

@seldondev
Copy link
Collaborator

Thu Nov 12 10:19:05 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2615/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2615 --build=2

@seldondev
Copy link
Collaborator

Thu Nov 12 10:19:12 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2615/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2615 --build=1

@anggao
Copy link
Contributor Author

anggao commented Nov 12, 2020

/test notebooks

@seldondev
Copy link
Collaborator

Thu Nov 12 10:43:27 UTC 2020
The logs for [notebooks] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2615/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2615 --build=3

@anggao
Copy link
Contributor Author

anggao commented Nov 12, 2020

@axsaucedo do you know why notebooks testings are still running, it has been running for over 10 hours ?

@axsaucedo
Copy link
Contributor

@anggao thank you for the heads up, I have just had alook, it seems the notebooks test got stuck - here are the logs:
image

The test is still running - it seems the KEDA test failed, and then the tracing test which ran afterwards started - it's not clear what is failing from the logs unfortunately.

@anggao
Copy link
Contributor Author

anggao commented Nov 13, 2020

That's weird, I don't think they did any breaking changes between beta and GA

@anggao
Copy link
Contributor Author

anggao commented Nov 13, 2020

Can we stop the current testing and try again ?

@axsaucedo
Copy link
Contributor

Yeah I just restarted all the components - let's retrigger
/test notebooks

@seldondev
Copy link
Collaborator

Fri Nov 13 17:21:52 UTC 2020
The logs for [notebooks] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2615/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2615 --build=4

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Wed Nov 18 17:17:44 UTC 2020
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2615/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2615 --build=6

@seldondev
Copy link
Collaborator

Wed Nov 18 17:19:28 UTC 2020
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2615/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2615 --build=5

@seldondev seldondev merged commit f48d5b3 into SeldonIO:master Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update KEDA example to use v2.0 GA version
3 participants