New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to use KEDA v2.0 GA version in the demo #2615
Conversation
Hi @anggao. Thanks for your PR. I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
/approve |
/ok-to-test |
Thu Nov 12 10:19:05 UTC 2020 impatient try |
Thu Nov 12 10:19:12 UTC 2020 impatient try |
/test notebooks |
Thu Nov 12 10:43:27 UTC 2020 impatient try |
@axsaucedo do you know why notebooks testings are still running, it has been running for over 10 hours ? |
@anggao thank you for the heads up, I have just had alook, it seems the notebooks test got stuck - here are the logs: The test is still running - it seems the KEDA test failed, and then the tracing test which ran afterwards started - it's not clear what is failing from the logs unfortunately. |
That's weird, I don't think they did any breaking changes between beta and GA |
Can we stop the current testing and try again ? |
Yeah I just restarted all the components - let's retrigger |
Fri Nov 13 17:21:52 UTC 2020 impatient try |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Wed Nov 18 17:17:44 UTC 2020 impatient try |
Wed Nov 18 17:19:28 UTC 2020 impatient try |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2614
Special notes for your reviewer:
Does this PR introduce a user-facing change?: